Skip to content

Add type hints to sample project scripts#104

Open
Xinart wants to merge 1 commit into
KoBeWi:masterfrom
Xinart:feature/add_type_support_to_sample_project
Open

Add type hints to sample project scripts#104
Xinart wants to merge 1 commit into
KoBeWi:masterfrom
Xinart:feature/add_type_support_to_sample_project

Conversation

@Xinart

@Xinart Xinart commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Added missing type hints on functions of scripts in the sample project (res://SampleProject/)

The goal is to complete the issue #103

@KoBeWi KoBeWi linked an issue Nov 3, 2025 that may be closed by this pull request
@KoBeWi

KoBeWi commented Nov 3, 2025

Copy link
Copy Markdown
Owner

I still get some warnings in Button.tscn, MiniPortal.tscn and DiceRoom.tscn.

@Xinart

Xinart commented Nov 27, 2025

Copy link
Copy Markdown
Contributor Author

I still get some warnings in Button.tscn, MiniPortal.tscn and DiceRoom.tscn.

Can you tell me what type of warning you got? i have none using Godot 4.5.1
(Sorry for the late reply)

@KoBeWi

KoBeWi commented Dec 8, 2025

Copy link
Copy Markdown
Owner
W 0:00:42:538   GDScript::reload: Variable "go" has no static type.
  <Błąd C++>    UNTYPED_DECLARATION
  <Źródło C++>  DiceRoom.tscn::GDScript_2fold:64 @ GDScript::reload()
W 0:00:42:538   GDScript::reload: Function "<anonymous lambda>()" has no static return type.
  <Błąd C++>    UNTYPED_DECLARATION
  <Źródło C++>  DiceRoom.tscn::GDScript_2fold:90 @ GDScript::reload()
W 0:03:15:542   GDScript::reload: Function "press()" has no static return type.
  <Błąd C++>    UNTYPED_DECLARATION
  <Źródło C++>  Button.tscn::GDScript_4b230:20 @ GDScript::reload()
W 0:00:09:091   GDScript::reload: Function "<anonymous lambda>()" has no static return type.
  <Błąd C++>    UNTYPED_DECLARATION
  <Źródło C++>  MiniPortal.tscn::GDScript_op7ae:23 @ GDScript::reload()

Also in the newly added loop rooms:

W 0:01:04:003   GDScript::reload: Variable "loop_target" has no static type.
  <Błąd GDScript>UNTYPED_DECLARATION
  <Źródło GDScript>LoopScript.gd:5 @ GDScript::reload()
W 0:01:04:003   GDScript::reload: Function "on_cell_changed()" has no static return type.
  <Błąd GDScript>UNTYPED_DECLARATION
  <Źródło GDScript>LoopScript.gd:35 @ GDScript::reload()
W 0:01:04:003   GDScript::reload: Function "on_room_changed()" has no static return type.
  <Błąd GDScript>UNTYPED_DECLARATION
  <Źródło GDScript>LoopScript.gd:45 @ GDScript::reload()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for GDScript strict type mode

2 participants