feat(InteractorStyleTrackballActor): add vtkInteractorStyleTrackballActor#3459
Draft
daker wants to merge 1 commit into
Draft
feat(InteractorStyleTrackballActor): add vtkInteractorStyleTrackballActor#3459daker wants to merge 1 commit into
daker wants to merge 1 commit into
Conversation
daker
force-pushed
the
feat-interactorstyletrackballactor
branch
2 times, most recently
from
50f219a to
c6b4f09
Compare
finetjul
reviewed
Mar 30, 2026
finetjul
left a comment
finetjul
left a comment
Member
There was a problem hiding this comment.
This does not behave like the interactor style trackball actor in VTK C++.
(e.g. pick top left corner, then drag mouse down, then drag mouse right)
In VTK.js, we prefer the more modern approach of "manipulators" (that will eventually land in VTK C++).
Collaborator
|
BTW, it has been merged on VTK/C++ https://gitlab.kitware.com/vtk/vtk/-/merge_requests/13039 |
daker
force-pushed
the
feat-interactorstyletrackballactor
branch
from
c6b4f09 to
bdb2a94
Compare
Member
|
@daker can you make it a manipulator instead ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
fix #1838
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting