Skip to content

API for getting debug info about a profile from engine - #1276

Merged
adamchalmers merged 5 commits into
mainfrom
achalmers/kcl-profile-dbg
Jul 17, 2026
Merged

API for getting debug info about a profile from engine#1276
adamchalmers merged 5 commits into
mainfrom
achalmers/kcl-profile-dbg

Conversation

@adamchalmers

@adamchalmers adamchalmers commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

@adamchalmers
adamchalmers force-pushed the achalmers/kcl-profile-dbg branch 2 times, most recently from 9f03db3 to 25b2ced Compare July 15, 2026 18:45
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@544b156). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1276   +/-   ##
=======================================
  Coverage        ?   31.40%           
=======================================
  Files           ?       36           
  Lines           ?     1799           
  Branches        ?        0           
=======================================
  Hits            ?      565           
  Misses          ?     1234           
  Partials        ?        0           
Flag Coverage Δ
unittests 31.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adamchalmers
adamchalmers force-pushed the achalmers/kcl-profile-dbg branch 2 times, most recently from 85d3135 to 0752a66 Compare July 16, 2026 16:49
@adamchalmers
adamchalmers force-pushed the achalmers/kcl-profile-dbg branch from 0752a66 to 55c7068 Compare July 16, 2026 18:52
@adamchalmers
adamchalmers marked this pull request as ready for review July 16, 2026 19:23
Comment thread modeling-cmds/openapi/api.json Outdated
]
},
{
"description": "Returns the closest edge to this point.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is wrong.

Returns information about the sketch curves and points?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good point, fixed.

@nadr0 nadr0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the rust comment for the openapi and we will be good to go

@nadr0 nadr0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the comment!

@adamchalmers
adamchalmers merged commit 5f6768e into main Jul 17, 2026
9 checks passed
@adamchalmers
adamchalmers deleted the achalmers/kcl-profile-dbg branch July 17, 2026 18:10
adamchalmers added a commit that referenced this pull request Jul 17, 2026
# Added

 - New debug endpoint, SketchGetInfo (#1276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants