Expose the new region segment isx resolver APIs from kevins toolpaths work#1247
Expose the new region segment isx resolver APIs from kevins toolpaths work#1247mlfarrell wants to merge 2 commits into
Conversation
|
still am unable to run API json update locally due to some python issues with my local machine |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
=======================================
Coverage ? 29.39%
=======================================
Files ? 34
Lines ? 1694
Branches ? 0
=======================================
Hits ? 498
Misses ? 1196
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| /// The total number of intersections between the two curves. | ||
| pub intersection_count: u32, | ||
| /// True if the region lies within the clockwise interior of the two intersections (inside a "right" turn from the segment to the intersection segment) | ||
| pub curve_clockwise: bool, |
There was a problem hiding this comment.
Here is the respective KCL call that will consume these values https://zoo.dev/docs/kcl-std/functions/std-sketch-region
When I compute the boolean false means CCW and true means CW. I am using it as an encoding.
KCL refers to this as Direction
There was a problem hiding this comment.
no worries, we should be good engine-side here
2 participants
Tagging @nadr0 if any questions come up about docs or API naming. These concepts are a bit difficult to explain.
https://github.com/KittyCAD/engine/pull/4704