Skip to content

Add new RefsSeed to some commands#1246

Open
lee-at-zoo-corp wants to merge 6 commits into
mainfrom
lee-at-zoo-corp/client-provided-ids
Open

Add new RefsSeed to some commands#1246
lee-at-zoo-corp wants to merge 6 commits into
mainfrom
lee-at-zoo-corp/client-provided-ids

Conversation

@lee-at-zoo-corp

@lee-at-zoo-corp lee-at-zoo-corp commented Jun 17, 2026

Copy link
Copy Markdown

Needed by https://github.com/KittyCAD/engine/pull/4702

I had to move some tests around because they were improperly outside of mod tests. Other than that the line additions is mostly from the new api.json.

@lee-at-zoo-corp lee-at-zoo-corp marked this pull request as draft June 17, 2026 19:32
@lee-at-zoo-corp lee-at-zoo-corp force-pushed the lee-at-zoo-corp/client-provided-ids branch from d387541 to c1ac501 Compare June 18, 2026 13:40
@lee-at-zoo-corp lee-at-zoo-corp marked this pull request as ready for review June 18, 2026 13:40
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e49a579). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage        ?   30.30%           
=======================================
  Files           ?       34           
  Lines           ?     1716           
  Branches        ?        0           
=======================================
  Hits            ?      520           
  Misses          ?     1196           
  Partials        ?        0           
Flag Coverage Δ
unittests 30.30% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant