Skip to content

MBD: edge specifiers#1244

Closed
adamchalmers wants to merge 6 commits into
mainfrom
achalmers/mbd-feature-edge-specifier
Closed

MBD: edge specifiers#1244
adamchalmers wants to merge 6 commits into
mainfrom
achalmers/mbd-feature-edge-specifier

Conversation

@adamchalmers

Copy link
Copy Markdown
Collaborator

Based on #1239 but with a few improvements:

  • The JSON deserializer checks that at least one of the variants was set, making impossible states unrepresentable
  • The JSON deserializer chooses which one to use if both were set, reducing engine code
  • The Rust builder API forces users to set one of the variants, making impossible states unrepresentable

@adamchalmers

Copy link
Copy Markdown
Collaborator Author

Closing because open-api lint complains about the single parameter accepting multiple types (either UUID or edge specifier) which is really annoying because I like this API but it's got a good point, it's hard for client generators to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants