Skip to content

Use stack allocated spans instead of heap allocated arrays #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Henr1k80 wants to merge 1 commit into
base: v17/main
Choose a base branch
from
Open

Use stack allocated spans instead of heap allocated arrays #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions uSync.Core/Extensions/ConversionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ internal static class ConversionExtensions

public static Guid ConvertToGuid(this int value)
{
byte[] bytes = new byte[16];
BitConverter.GetBytes(value).CopyTo(bytes, 0);
Span<byte> bytes = stackalloc byte[16];
BitConverter.GetBytes(value).CopyTo(bytes);
return new Guid(bytes);
}
}
2 changes: 1 addition & 1 deletion uSync.Core/Extensions/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static string ToShortKeyString(this Guid guid, int length = 26)
// a Guid is 3 blocks + 8 bits

// so it turns into a 3*8+2 = 26 chars string
var chars = new char[length];
Span<char> chars = stackalloc char[length];

var i = 0;
var j = 0;
Expand Down