fix(DataMapper): Preserve descendant overrides across choice selection changes#3308
fix(DataMapper): Preserve descendant overrides across choice selection changes#3308mmelko wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
8a9fa17 to
37a626b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3308 +/- ##
==========================================
- Coverage 92.60% 92.60% -0.01%
==========================================
Files 650 650
Lines 25424 25410 -14
Branches 5847 6059 +212
==========================================
- Hits 23544 23531 -13
+ Misses 1878 1770 -108
- Partials 2 109 +107 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…n changes Fix KaotoIO#3234 Fix KaotoIO#3232 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
37a626b to
11976d3
Compare
|



Summary
Choice selection no longer cascade-invalidates descendant overrides (substitutions, type overrides, nested choices)
Fixes "Reset Override" silently failing when substitution was selected before choice
Root cause: invalidateDescendants() removed substitution from definition but resetDescendantFields() didn't clear selectedMemberIndex on the live field — state inconsistency
Fix #3234
Fix #3232
Screen.Recording.2026-06-12.at.16.11.26.mov
Summary by CodeRabbit
Tests
Refactor