clipboard enhancements#1327
Open
lokeshlkr wants to merge 4 commits into
Open
Conversation
Contributor
Author
lokeshlkr
changed the title
Contributor
Author
|
changes:
|
Julow
reviewed
Jun 20, 2026
Julow
left a comment
Julow
left a comment
Owner
There was a problem hiding this comment.
Thanks a lot for this :)
I think there's too much margin around the text (above and below and with the number). It's taking too much space in landscape mode notably.
| @@ -0,0 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Owner
There was a problem hiding this comment.
It's not the right place. The resources are in res/.
Also I prefer that the name refer to what its used for instead of what it does at the moment, for example clipboard_item_background.
Comment on lines
+8
to
+12
| <TextView android:id="@+id/clipboard_pin_text" style="@style/clipboardEntry" | ||
| android:layout_width="0dp" android:layout_weight="150" | ||
| android:background="@drawable/rounded_corner" | ||
| android:backgroundTint="#19FFFFFF" android:maxLines="3" | ||
| android:padding="5dp" /> |
Owner
There was a problem hiding this comment.
A lot of the new attributes are duplicated in clipboard_history_entry.xml. Can you move them to the clipboardEntry style in res/values/styles.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
maxLinesattribute on clipboard history text view.its set to 3 lines, same as already present for pinned items text view.
addresses issue #1321