Fix platform_profile compilation by relying on kernel version instead of "lts" flag - #289
Open
ArKT-7 wants to merge 2 commits into
Open
Fix platform_profile compilation by relying on kernel version instead of "lts" flag#289ArKT-7 wants to merge 2 commits into
ArKT-7 wants to merge 2 commits into
Conversation
… of 'lts' flag The platform_profile API was introduced in Linux 5.12. Previously, the build script passed 'lts' flag that forced legacy dummy functions to compile, causing conflicting type errors on modern kernels. By doing this change, the module now compiles on all modern kernels while still preserving the dummy functions for any legacy kernel older than 5.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this awesome module.
I ran into a compilation error recently while trying to install this on a newer kernel (Linux 6.18 on CachyOS/Arch)
The platform_profile API was officially introduced in Linux 5.12. Previously, the build script passed 'lts' flag that forced legacy dummy functions to compile, causing conflicting type errors on modern kernels. Now, the module compiles perfectly while still preserving the dummy functions for any legacy kernel older than 5.12.