WIP: Add Acer Nitro AN16S-61 - #269
Open
RubenGarcia wants to merge 3 commits into
Open
Conversation
Author
Author
|
I think the addition of the status check for wmi_evaluate_method is useful. |
|
hey did anything work for you i have the same device |
Author
|
The brightness of the keyboard can be changed between 0 and 100 but the rest of the parameters do not change anything. Values over 100 are accepted, but the leds get very bright with erratic blinking, so I suspect they are out-of-spec and would burn if kept like this for a long time. I think we should clamp the value to 100, at least in this model. I was mostly interested in being able to turn the light off, so that's already good progress from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the device, but keyboard light still does not work.