forked from nasa/fprime
-
Notifications
You must be signed in to change notification settings - Fork 0
Merge global and config interface targets into unified project interface #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
2
commits into
devel
Choose a base branch
from
devin/1781141221-merge-interface-targets
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #### | ||
| # project_interface.cmake: | ||
| # | ||
| # Defines the unified F Prime project interface target. This single INTERFACE library | ||
| # replaces both the global interface target (formerly in API.cmake) and the configuration | ||
| # interface target (formerly in config_assembler.cmake). It aggregates: | ||
| # | ||
| # - Global include directories (source and binary locations) | ||
| # - Build location properties (FPRIME_SOURCE_LOCATIONS, FPRIME_BINARY_LOCATIONS) | ||
| # - Configuration module dependencies and chosen implementations | ||
| # | ||
| # Custom target properties: | ||
| # FPRIME_SOURCE_LOCATIONS: list of source directories registered as build locations | ||
| # FPRIME_BINARY_LOCATIONS: list of binary directories registered as build locations | ||
| # FPRIME_CHOSEN_IMPLEMENTATIONS: list of chosen implementations from config modules | ||
| #### | ||
| include_guard() | ||
|
|
||
| set(FPRIME_PROJECT_INTERFACE_TARGET "_fprime_project_interface" CACHE INTERNAL | ||
| "Unified F Prime project interface target" FORCE) | ||
|
|
||
| if (NOT TARGET "${FPRIME_PROJECT_INTERFACE_TARGET}") | ||
| add_library("${FPRIME_PROJECT_INTERFACE_TARGET}" INTERFACE) | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Fw_Types now transitively inherits all global include directories via link dependency
The old
__fprime_configtarget was a pure aggregation target that only carried config module link dependencies and FPRIME_CHOSEN_IMPLEMENTATIONS. The new_fprime_project_interfacetarget also carries INTERFACE_INCLUDE_DIRECTORIES (all build root paths, config dirs, etc.). SinceFw_Typesdepends on_fprime_project_interface(atFw/Types/CMakeLists.txt:20), and all modules transitively depend onFw_Types, every module now inherits these include directories via the target dependency chain IN ADDITION to the existing directory-scopedinclude_directories(). This is functionally redundant (compilation behavior unchanged) but could have implications forINTERFACE_INCLUDE_DIRECTORIESpropagation in shared library exports or install targets. This is a subtle behavioral change that may be intentional but should be confirmed.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation. This is an intentional consequence of merging the two targets — the old
__fprime_configwas already a dependency ofFw_Types, and all modules already received these include directories via the directory-scopedinclude_directories()bridge. The transitive propagation through the target dependency chain is functionally redundant and shouldn't affect compilation behavior. For install/export scenarios this is worth monitoring but the existinginclude_directories()bridge already makes these globally visible.