Skip to content

Assert on channel ID present in both packet and ignore lists in TlmPacketizer #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: devel
Choose a base branch
from
+3 −0
Open

Assert on channel ID present in both packet and ignore lists in TlmPacketizer #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c31a537
Assert on channel ID in both packet and ignore lists in TlmPacketizer
devin-ai-integration[bot] Jun 10, 2026
4c778a1
Update comment per review feedback
devin-ai-integration[bot] Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Svc/TlmPacketizer/TlmPacketizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ void TlmPacketizer::setPacketList(const TlmPacketizerPacketList& packetList,
}
const Fw::Success insertStatus = this->m_channelIndices.insert(id, entryIndex);
FW_ASSERT(insertStatus == Fw::Success::SUCCESS, static_cast<FwAssertArgType>(insertStatus));
} else {
// Ensure it is a duplicate in the ignore list, not a duplicate of a valid channel
FW_ASSERT(this->m_channels[entryIndex].ignored, static_cast<FwAssertArgType>(id));
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
}
// is ignored channel - update entry in place via reference
TlmEntry& entry = this->m_channels[entryIndex];
Expand Down
Loading