Annotate review agent comments with reviewer label prefix

[devin-ai-integration]

Related Issue(s)	N/A
Has Unit Tests (y/n)	n
Documentation Included (y/n)	y (agent spec updates are the docs)
Generative AI was used in this contribution (y/n)	AI

---

Change Description

Adds a visible [<review_label>] prefix to every inline review comment posted by the multi-agent review system, so readers can immediately tell which reviewer agent produced a finding without expanding the hidden HTML footer.

Before: **must fix** Unbounded copy from ground argument.
After: [Security] **must fix** Unbounded copy from ground argument.

Labels per agent (review_label in agent-registry.yml):

Agent	Label
security-review	[Security]
supply-chain-review	[Supply Chain]
fprime-code-review	[C++ Design]
stale-documentation-review	[Documentation]
design-review	[Design]
test-quality-review	[Test Quality]

Files changed:

• agent-registry.yml — new review_label field on each reviewer entry
• review-contract.md §1, §7, §9 — updated comment body shapes (fresh finding, resolution reply, improper-resolution reply, disagreement escalation, incorrect-fix follow-up)
• post-inline-review.skill.md — updated all example bodies
• triage-classifier.skill.md — updated opening description
• re-review-state.skill.md — updated incorrect-fix, re-introduced, and resolution templates
• fprime-code-review.agent.md — updated CPP-1 worked example
• design-review.agent.md — updated adjudication example
• ci-test-runtime-policy.skill.md — updated multi-indicator worked example

Rationale

When multiple review agents post findings on the same PR, it is not immediately obvious which agent produced which comment. The hidden <!-- fprime-agent: ... --> footer carries this info but is invisible by default. A visible bracket prefix makes attribution instant.

Testing/Review Recommendations

Review the updated comment body shapes in review-contract.md §9 to confirm the [<review_label>] prefix is correctly placed before the triage tag in all shapes.

Future Work

N/A

AI Usage (see policy)

AI was used for code generation and editing of the agent spec files.

IAMAI

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/37b81cf5bc2e47e4bdf4b9da577bcbe5

---

[devin-ai-integration]

Original prompt from michael.d.starch

On our review agents flow in nasa fprime, can we annotate comments with the reviewer they come from?

E.g.

[Security Review] This line interoduces a buffer overflow

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR that start with 'DevinAI' or '@devin'.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[github-actions]

Coverage report — base devel

No baseline branch coverage/devel found. This run becomes the seed once it lands on devel.

Overall (line): 81.30% (no baseline)
Regression threshold: 0.50% (line).

Regressions

(none over threshold)

Modules changed

(no measurable change)

New modules

Module	Line	Function	Branch
CFDP/Checksum	71.15	57.14	44.44
Drv/AsyncByteStreamBufferAdapter	100.00	100.00	100.00
Drv/ByteStreamBufferAdapter	100.00	100.00	80.00
Drv/Ip	43.88	57.38	20.94
Drv/TcpClient	75.00	100.00	31.03
Drv/TcpServer	84.72	100.00	44.26
Drv/Udp	72.34	90.91	37.50
Fw/Buffer	81.25	89.47	43.75
Fw/DataStructures	98.48	97.14	57.37
Fw/Dp	94.83	96.67	47.92
Fw/FilePacket	75.24	89.06	41.43
Fw/Log	71.43	72.41	34.48
Fw/Logger	100.00	100.00	62.50
Fw/SerializableFile	90.00	100.00	44.44
Fw/Time	88.62	85.48	50.00
Fw/Tlm	53.76	60.00	24.29
Fw/Types	54.63	57.49	29.48
Os	18.88	20.59	12.70
Os/Generic	89.10	96.30	48.02
Os/Generic/Types	92.45	91.67	60.94
Os/Posix	60.75	83.72	39.74
Svc/ActiveRateGroup	100.00	100.00	60.87
Svc/ActiveTextLogger	79.05	90.00	53.85
Svc/AssertFatalAdapter	94.55	100.00	59.09
Svc/BufferAccumulator	88.00	94.12	54.79
Svc/BufferLogger	92.62	86.96	57.46
Svc/BufferManager	99.05	100.00	55.93
Svc/BufferRepeater	91.67	100.00	55.56
Svc/ChronoTime	100.00	100.00	50.00
Svc/CmdDispatcher	96.97	91.67	52.60
Svc/CmdSequencer	93.89	97.12	56.64
Svc/CmdSplitter	100.00	100.00	54.55
Svc/ComLogger	97.37	91.67	59.15
Svc/ComSplitter	100.00	100.00	66.67
Svc/ComStub	98.51	100.00	59.76
Svc/DpCatalog	78.00	100.00	42.92
Svc/DpManager	97.44	100.00	52.27
Svc/DpWriter	97.58	90.00	62.07
Svc/FileDownlink	84.15	90.91	45.29
Svc/FileManager	88.41	93.33	50.45
Svc/FileUplink	92.78	96.55	54.78
Svc/FileWorker	92.33	100.00	45.11
Svc/FprimeDeframer	100.00	100.00	58.04
Svc/FprimeFramer	100.00	100.00	42.19
Svc/FprimeRouter	88.89	100.00	48.65
Svc/FpySequencer	86.41	99.02	51.67
Svc/GenericHub	100.00	100.00	50.29
Svc/Health	100.00	100.00	60.00
Svc/LinuxTimer	97.06	100.00	47.06
Svc/OsTime	70.00	83.33	37.80
Svc/PassiveRateGroup	100.00	100.00	52.50
Svc/PolyDb	100.00	100.00	42.50
Svc/PosixTime	100.00	100.00	50.00
Svc/PrmDb	92.20	90.00	51.29
Svc/RateGroupDriver	100.00	100.00	62.50
Svc/SeqDispatcher	73.08	80.00	49.18
Svc/StaticMemory	100.00	100.00	55.00
Svc/SystemResources	98.63	100.00	55.00
Svc/TlmChan	82.11	85.71	47.83
Svc/TlmPacketizer	92.54	100.00	54.30
Svc/Version	96.10	100.00	54.91
Utils	19.93	26.44	14.53
Utils/Types	92.11	95.83	58.45

Modules without UTs

CFDP/Checksum/GTest, Drv/ByteStreamDriverModel, Drv/Interfaces, Drv/LinuxGpioDriver, Drv/LinuxI2cDriver, Drv/LinuxSpiDriver, Drv/LinuxUartDriver, Drv/Ports, Drv/Ports/DataTypes, FppTestProject/FppTest/interfaces, FppTestProject/FppTest/topology/async, FppTestProject/FppTest/topology/components/Comp, FppTestProject/FppTest/topology/components/Framework, FppTestProject/FppTest/topology/components/Receiver, FppTestProject/FppTest/topology/components/Sender, FppTestProject/FppTest/topology/guarded, FppTestProject/FppTest/topology/ports, FppTestProject/FppTest/topology/sync, FppTestProject/FppTest/topology/top_ports, FppTestProject/FppTest/topology/types, Fw/Cmd, Fw/Com, Fw/Comp, Fw/FilePacket/GTest, Fw/Fpy, Fw/Interfaces, Fw/Obj, Fw/Port, Fw/Ports/CompletionStatus, Fw/Ports/Ready, Fw/Ports/Signal, Fw/Ports/SuccessCondition, Fw/Prm, Fw/SerializableFile/test/TestSerializable, Fw/Sm, Fw/Test, Fw/Types/GTest, Os/Models, Svc/Cycle, Svc/DpPorts, Svc/Fatal, Svc/FatalHandler, Svc/FileDownlinkPorts, Svc/FprimeProtocol, Svc/Interfaces, Svc/PassiveConsoleTextLogger, Svc/Ping, Svc/PolyIf, Svc/Ports/CommsPorts, Svc/Ports/FilePorts, Svc/Ports/OsTimeEpoch, Svc/Ports/TlmPacketizerPorts, Svc/Ports/VersionPorts, Svc/Sched, Svc/Seq, Svc/Subtopologies/CdhCore, Svc/Subtopologies/ComCcsds, Svc/Subtopologies/ComFprime, Svc/Subtopologies/ComLoggerTee, Svc/Subtopologies/DataProducts, Svc/Subtopologies/FileHandling, Svc/Types/TlmPacketizerTypes, Svc/WatchDog, TestDeploymentsProject/Ref/PingReceiver, TestDeploymentsProject/Ref/RecvBuffApp, TestDeploymentsProject/Ref/SendBuffApp, TestDeploymentsProject/Ref/Top, TestDeploymentsProject/Ref/TypeDemo, Utils/Hash, cmake/test/data/TestDeployment/TestBuildAutocoder, cmake/test/data/TestDeployment/TestChainedAutocoder, cmake/test/data/TestDeployment/TestHeaderAutocoder, cmake/test/data/TestDeployment/TestTargetAutocoder, cmake/test/data/test-fprime-library/TestLibrary/TestComponent, cmake/test/data/test-fprime-library2/TestLibrary2/TestComponent

[devin-ai-integration]

Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it.