percolate replay goal from --analyse-from args instead of forcing genesis point in db-analyser.#2060
Open
KtorZ wants to merge 1 commit into
Open
Conversation
…esis point in db-analyser.
ede333f to
a97546c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We use db-analyser to produce ledger snapshots at specific points in time. However, the
--analyze-fromoption is completely ignored and causes db-analyser to always revalidate the entire ledger state from genesis instead of using available ledger snapshots.For example, I have a snapshot available at 119750386 and running db-analyser will cause a full replay from genesis.
With this commit; the ledger db is now correctly continuing from an available snapshot:
(cc @jasagredo as discussed in Porto; I believe this fixes the problem?)