Skip to content

Enable P2P topology in cardano-testnet - #6263

Merged
nbacquey merged 9 commits into
masterfrom
nb/refactor_topology
Jul 16, 2025
Merged

Enable P2P topology in cardano-testnet#6263
nbacquey merged 9 commits into
masterfrom
nb/refactor_topology

Conversation

@nbacquey

@nbacquey nbacquey commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Description

This PR does two things:

  • Enable cardano-testnet to use P2P topology
  • Dump an abstract topology file with cardano-testnet create-env, which can be customized by the user before running the testnet.

Closes #6150

Review should be done commit by commit

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
  • Any changes are noted in the CHANGELOG.md for affected package
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@nbacquey
nbacquey force-pushed the nbacquey/dump_config branch from fb0c257 to ba03c10 Compare June 25, 2025 12:44
@nbacquey
nbacquey force-pushed the nb/refactor_topology branch from 5c1ab7b to a3624d3 Compare June 25, 2025 12:45
Base automatically changed from nbacquey/dump_config to master June 25, 2025 18:25
@nbacquey
nbacquey force-pushed the nb/refactor_topology branch 2 times, most recently from fa222ca to 0ebb1f7 Compare July 2, 2025 16:48
@nbacquey
nbacquey marked this pull request as ready for review July 2, 2025 16:59
@nbacquey
nbacquey requested a review from a team as a code owner July 2, 2025 16:59
@nbacquey nbacquey changed the title WIP: Create abstract topology in testnet sandbox Enable P2P topology in cardano-testnet Jul 2, 2025
Comment thread cardano-testnet/src/Testnet/Start/Cardano.hs Outdated
Comment thread cardano-testnet/src/Testnet/Start/Cardano.hs Outdated
Comment thread cardano-node/src/Cardano/Node/Configuration/Topology.hs Outdated
Comment thread cardano-testnet/src/Testnet/Start/Cardano.hs Outdated
Comment thread cardano-testnet/src/Testnet/Start/Cardano.hs Outdated
Comment thread cardano-node/src/Cardano/Node/Configuration/TopologyP2P.hs Outdated
Comment thread cardano-node/src/Cardano/Node/Configuration/Topology.hs Outdated
Comment thread cardano-node/src/Cardano/Node/Configuration/Topology.hs Outdated
Comment thread cardano-testnet/src/Testnet/Start/Cardano.hs
Comment thread cardano-node/src/Cardano/Node/Configuration/TopologyP2P.hs Outdated
Comment thread cardano-testnet/src/Testnet/Components/Configuration.hs
Comment thread cardano-testnet/src/Testnet/Start/Cardano.hs
Comment thread cardano-testnet/src/Testnet/Start/Cardano.hs Outdated
@nbacquey
nbacquey force-pushed the nb/refactor_topology branch 2 times, most recently from d361c74 to c4b928c Compare July 7, 2025 07:59
@nbacquey
nbacquey force-pushed the nb/refactor_topology branch from c4b928c to 38db4bf Compare July 7, 2025 14:09
@nbacquey
nbacquey requested review from Jimbo4350 and carbolymer July 8, 2025 18:57
@coot

coot commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

It's a nice change to see, as we're going to remove non-P2P mode.

@Jimbo4350
Jimbo4350 self-requested a review July 16, 2025 12:12
@nbacquey
nbacquey added this pull request to the merge queue Jul 16, 2025
Merged via the queue into master with commit 3974c04 Jul 16, 2025
24 checks passed
@nbacquey
nbacquey deleted the nb/refactor_topology branch July 16, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cardano-testnet: create P2P topology file when user provided's node configuration file requests one

4 participants