Enable P2P topology in cardano-testnet - #6263
Merged
Merged
Conversation
nbacquey
force-pushed
the
nbacquey/dump_config
branch
from
June 25, 2025 12:44
fb0c257 to
ba03c10
Compare
nbacquey
force-pushed
the
nb/refactor_topology
branch
from
June 25, 2025 12:45
5c1ab7b to
a3624d3
Compare
nbacquey
force-pushed
the
nb/refactor_topology
branch
2 times, most recently
from
July 2, 2025 16:48
fa222ca to
0ebb1f7
Compare
nbacquey
marked this pull request as ready for review
July 2, 2025 16:59
cardano-testnet
carbolymer
reviewed
Jul 3, 2025
carbolymer
reviewed
Jul 3, 2025
carbolymer
reviewed
Jul 3, 2025
carbolymer
reviewed
Jul 3, 2025
carbolymer
reviewed
Jul 3, 2025
carbolymer
reviewed
Jul 3, 2025
Jimbo4350
reviewed
Jul 3, 2025
nbacquey
force-pushed
the
nb/refactor_topology
branch
2 times, most recently
from
July 7, 2025 07:59
d361c74 to
c4b928c
Compare
nbacquey
force-pushed
the
nb/refactor_topology
branch
from
July 7, 2025 14:09
c4b928c to
38db4bf
Compare
Contributor
|
It's a nice change to see, as we're going to remove non-P2P mode. |
Jimbo4350
self-requested a review
July 16, 2025 12:12
Jimbo4350
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
cardano-testnetto use P2P topologycardano-testnet create-env, which can be customized by the user before running the testnet.Closes #6150
Review should be done commit by commit
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected packagehlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.