Read dark-mode setting from the desktop portal#6
Open
TingPing wants to merge 1 commit into
Open
Conversation
There are numerous ways to make a GTK theme dark The GtkSettings value is deprecated: https://docs.gtk.org/gtk4/property.Settings.gtk-application-prefer-dark-theme.html The GSettings value isn't deprecated but was never a documented standard outside of GNOME and has the downside of not being accurate inside of any sandbox. The portal setting is a standardized value that multiple desktops set. This was problematic for the `wig` project which uses libadwaita, so the platform and application can be completely out of sync regarding dark mode. libadwaita also respects the portal value. libportal was used for convenience, but it's just some basic dbus usage if that's preferred.
Collaborator
|
I prefer not to add a dependency just for a dbus call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are numerous ways to make a GTK theme dark
The GtkSettings value is deprecated: https://docs.gtk.org/gtk4/property.Settings.gtk-application-prefer-dark-theme.html
The GSettings value isn't deprecated but was never a documented standard outside of GNOME and has the downside of not being accurate inside of any sandbox.
The portal setting is a standardized value that multiple desktops set.
This was problematic for the
wigproject which uses libadwaita, so the platform and application can be completely out of sync regarding dark mode. libadwaita also respects the portal value.libportal was used for convenience, but it's just some basic dbus usage if that's preferred.