HA: Always check realization context deadline#1138
Open
oxzi wants to merge 1 commit into
Open
Conversation
oxzi
force-pushed
the
ha-realize-ctx-deadline-exceeded
branch
from
79e500a to
6216701
Compare
The HA realization logic is bound to a context with a deadline based on the latest heartbeat message expiration time. Within the realize method, a database transaction is used - also honoring this context - within a retry.WithBackoff wrapper. The retry.WithBackoff function returns the inner function's error, even when the context's deadline has exceeded. While this is intentional and useful, it might hide a relation to a context issue. In this case, the exceeding context cancels the database transaction, resulting in a PostgreSQL cancellation, which is being returned as an error on its own. > pq: canceling statement due to user request (57014) When returning from the realize method, only the error is inspected, not the context with the deadline. Thus, the special case for an exceeded deadline is being skipped in this case.
oxzi
force-pushed
the
ha-realize-ctx-deadline-exceeded
branch
from
6216701 to
4f47eb8
Compare
oxzi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HA realization logic is bound to a context with a deadline based on the latest heartbeat message expiration time. Within the realize method, a database transaction is used - also honoring this context - within a retry.WithBackoff wrapper.
The retry.WithBackoff function returns the inner function's error, even when the context's deadline has exceeded. While this is intentional and useful, it might hide a relation to a context issue.
In this case, the exceeding context cancels the database transaction, resulting in a PostgreSQL cancellation, which is being returned as an error on its own.
When returning from the realize method, only the error is inspected, not the context with the deadline. Thus, the special case for an exceeded deadline is being skipped in this case.
Fixes #1137. This comment in the issue explains a bit more about the reasoning.
I would be happy if you, @IPB-DevOps, are able to test this PR (in a non-production setup). Same goes for you, @nilmerg.