Skip to content

docs: the legacy project was DeepSeek-TUI, not "DeepSeek CLI" - #5984

Open
Hmbown wants to merge 1 commit into
mainfrom
pr/license-deepseek-tui
Open

docs: the legacy project was DeepSeek-TUI, not "DeepSeek CLI"#5984
Hmbown wants to merge 1 commit into
mainfrom
pr/license-deepseek-tui

Conversation

@Hmbown

@Hmbown Hmbown commented Sep 7, 2026

Copy link
Copy Markdown
Owner

No-Issue: corrects a project name in a copyright attribution line; no behaviour change and no tracker entry

Both LICENSE files and one app-server doc comment attributed copyright to "DeepSeek CLI Contributors" — a project name that never existed. The lineage is DeepSeek-TUI, which is also what the retained legacy npm package is called (npm/deepseek-tui, kept private and never republished).

This corrects a project name, not the license.

Verified: with line 3 removed, both LICENSE files are byte-identical to their previous contents, so the MIT text, the year range and the copyright-holder shape are untouched.

LICENSE:3                     Copyright (c) 2024-2025 [-DeepSeek CLI-]{+DeepSeek-TUI+} Contributors
extensions/vscode/LICENSE:3   Copyright (c) 2024-2025 [-DeepSeek CLI-]{+DeepSeek-TUI+} Contributors
crates/app-server/src/lib.rs  /// CodeWhale began life as [-a DeepSeek CLI-]{+DeepSeek-TUI+}; ...

Deliberately not changed, because they are not attribution:

  • crates/tui/src/tools/review.rsdeepseek-ai/deepseek-cli is a test URL for the PR-URL parser
  • crates/cli/src/lib.rsdeepseek-cli-auth-*-test are temp filenames
  • npm/deepseek-tui/package.json — the deprecated legacy package name

No build impact: the Rust change is prose inside a /// comment.

🤖 Generated with Claude Code

https://claude.ai/code/session_01D4rk4NXwyy6wmvii9Lp84P


Devin Review

Note

Low Risk
Documentation and copyright attribution only; no executable code or license terms changed.

Overview
Fixes incorrect attribution to a non-existent "DeepSeek CLI" project by renaming the copyright holder to DeepSeek-TUI Contributors in the root LICENSE and extensions/vscode/LICENSE. Only line 3 of each license file changes; MIT terms, year range, and holder wording stay the same.

Updates the legacy_deepseek_compat doc comment in crates/app-server/src/lib.rs so it says CodeWhale began as DeepSeek-TUI, matching the real lineage and the legacy npm/deepseek-tui package. No runtime or API behavior changes—comment-only in Rust.

Reviewed by Cursor Bugbot for commit 18d5f95. Bugbot is set up for automated code reviews on this repo. Configure here.

Both LICENSE files and one app-server doc comment attributed copyright to
"DeepSeek CLI Contributors" — a project name that never existed. The
founder confirmed the lineage is DeepSeek-TUI, which is also what the
retained legacy npm package is called (npm/deepseek-tui, kept private and
never republished).

This corrects a project name, not the license. Verified: with line 3
removed, both LICENSE files are byte-identical to their previous contents,
so the MIT text, the year range and the copyright holder shape are
untouched.

Deliberately NOT changed, because they are not attribution:
- crates/tui/src/tools/review.rs — `deepseek-ai/deepseek-cli` is a test URL
  for the PR-URL parser
- crates/cli/src/lib.rs — `deepseek-cli-auth-*-test` are temp filenames
- npm/deepseek-tui/package.json — the deprecated legacy package name

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D4rk4NXwyy6wmvii9Lp84P
Signed-off-by: CodeWhale Bot <bot@codewhale.net>
Copilot AI lite review requested due to automatic review settings September 7, 2026 07:36
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_a2244405-6eb6-47c5-92b6-bd2bd33df9a8)

@claude

claude Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished @Hmbown's task in 29s —— View job


Review: docs — DeepSeek-TUI attribution fix

  • Gather context (diff, changed files)
  • Understand the request (doc-only correction, review per repo guidelines)
  • Verify LICENSE files remain byte-identical apart from the name change
  • Check the app-server comment change and confirm no other stray references
  • Post final review

Summary: This is a clean, minimal, correct documentation fix. Verified via git diff origin/main...HEAD:

  • LICENSE and extensions/vscode/LICENSE: only line 3 changes (DeepSeek CLI ContributorsDeepSeek-TUI Contributors), no other bytes touched — matches the PR description's claim.
  • crates/app-server/src/lib.rs:38: doc-comment prose only (/// CodeWhale began life as DeepSeek-TUI; ...), no code/behavior impact.
  • Repo-wide grep for DeepSeek CLI after the change returns zero matches — the rename is complete and consistent, no stray attributions left behind.

Checked against the review priorities (correctness, provider/model-route safety, reuse/simplification, tests, security) — none apply here; this is prose-only with no build or runtime impact. The PR's own "deliberately not changed" list (review.rs test URL, cli/src/lib.rs temp filenames, npm/deepseek-tui/package.json legacy package name) is correct — those are not attribution and shouldn't be touched.

No issues found. LGTM.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T07:39:07.649364Z 18d5f95 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Changes are limited to attribution/documentation text and match the stated PR intent without affecting executable behavior.

Pull request overview

Corrects legacy attribution text to refer to the historically accurate project name DeepSeek-TUI (not “DeepSeek CLI”) in license headers and a Rust doc comment, without changing license terms or runtime behavior.

Changes:

  • Update the copyright holder name in the root LICENSE.
  • Apply the same copyright holder correction in extensions/vscode/LICENSE.
  • Fix the crates/app-server documentation comment to state CodeWhale originated as DeepSeek-TUI.
File summaries
File Description
LICENSE Corrects the project name in the copyright line to “DeepSeek-TUI Contributors”.
extensions/vscode/LICENSE Mirrors the same attribution correction for the VS Code extension’s license file.
crates/app-server/src/lib.rs Updates a doc comment to reflect the correct historical lineage (“DeepSeek-TUI”).
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codewhale-agent codewhale-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewhale review

Documentation-only PR that corrects the legacy project name in copyright attribution from the non-existent "DeepSeek CLI Contributors" to "DeepSeek-TUI Contributors" in both LICENSE files and updates a Rust doc comment to match.

Assessment

Looks good. The change is limited to copyright attribution and a doc comment, has no runtime or API impact, and matches the retained legacy package name. No tests or tracker entry are required for this kind of correction.


Advisory review by Codewhale (codewhale review --pr 5984 --post, head 18d5f95edde2d483b874233d7afd57ab0a529904). Line-specific findings are also posted as inline review comments; mechanical fixes arrive as committable suggestions you can apply from the Files tab. CODEOWNERS approval still governs merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants