fix(tui): simplify single-row model picker titles - #4203
Closed
nightt5879 wants to merge 1 commit into
Closed
Conversation
Render scrollable picker panes with a single visible row as a position, e.g. Model 2/3, instead of a degenerate range like Model 2-2/3. Multi-row panes keep the existing start-end range. Fixes Hmbown#3995
Owner
Closed
83 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Title N/totalTitle start-end/totalformat for multi-row scroll windowsFixes #3995
Validation
cargo fmt --all --checkcargo test -p codewhale-tui --bin codewhale-tui --locked pane_title -- --nocapturecargo test -p codewhale-tui --bin codewhale-tui --locked model_picker -- --nocapturecargo clippy --workspace --all-features --locked -- -D warnings -A clippy::uninlined_format_args -A clippy::too_many_arguments -A clippy::unnecessary_map_or -A clippy::collapsible_if -A clippy::assertions_on_constants -A clippy::collapsible_matchAdditional local signal:
cargo test -p codewhale-tui --bin codewhale-tui --lockedran the full TUI bin suite; unrelated local environment issues were isolated to real provider auth state and a transient Windows temp-file replace failure, and each failing test passed when rerun in isolation.