fix(rmk-config): let alias names end at delimiters, not just whitespace#926
Merged
Conversation
`LM(1, @mods)` used to fail with `Undefined alias: mods)` because the alias name only ended at whitespace. Names now end at the keymap grammar's delimiter set (whitespace, parens, comma, `@`), so aliases work directly inside action arguments; a bare `@` before a delimiter stays literal, and adjacent `@a@b` now resolves as two aliases. Alias keys containing a delimiter are rejected up front since they could never be referenced. Signed-off-by: Haobo Gu <haobogu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LM(1, @mods)used to fail withUndefined alias: mods)because an alias name only ended at whitespace, forcing the awkward@mods )workaround.(,),,,@), so aliases work directly inside action arguments@before a delimiter stays literal; adjacent@a@bnow resolves as two aliasesVerification: five new unit tests + one
keyboard_toml_validationintegration test; fullrmk-configsuite passes (81).Part of the post-review follow-ups for #848.