refactor: dedup rynk test frame decoding and encoder persist, fix stale refs#925
Merged
Merged
Conversation
…le refs - Share the Frame view (envelope/raw decode): it lives in rynk_link and the HID-framed rynk_hid_link imports it, instead of each keeping a copy. - Fold set_encoder_clockwise / set_encoder_counter_clockwise into one set_encoder_direction, collapsing Vial's SetEncoder arms. - Update three doc references to drop_report_padding (renamed to RynkHidFrameTracker) and the stale 'Rynk next' context header. Signed-off-by: Haobo Gu <haobogu@outlook.com>
HaoboGu
force-pushed
the
simplify/rynk-review-cleanups
branch
from
8d5abdc to
0c101b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanups from the #848 branch review — no behavior change:
Frameview (envelope/raw decode) between the two loopback harnesses: it lives inrynk_linkand the HID-framedrynk_hid_linkimports it, instead of each keeping a copyset_encoder_clockwise/set_encoder_counter_clockwiseinto oneset_encoder_direction, collapsing Vial'sSetEncoderarmsdrop_report_padding(renamed toRynkHidFrameTracker) and the stale "Vial today, Rynk next" context headerVerification: rynk suite (617) and vial suite (526) pass. +17/−56.
Part of the post-review follow-ups for #848.