Skip to content

docs: revert version-1.0 CLI flags from grpc-* back to rpc-*#2516

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/update-docs-align-grpc-cli-options
Closed

docs: revert version-1.0 CLI flags from grpc-* back to rpc-*#2516
Copilot wants to merge 3 commits into
mainfrom
copilot/update-docs-align-grpc-cli-options

Conversation

Copilot AI commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What's Changed in this PR

Reverts the previous version-1.0 docs change that renamed CLI flags from rpc-* to grpc-*.

Based on feedback and verification against stable v1.0.x behavior, the grpc-* CLI naming is not supported in stable v1.0.0/v1.0.1/v1.0.2. This PR restores rpc-* flags in version-1.0 docs (EN + ZH) for installation and command-line reference pages, so version-1.0 matches actual stable binaries.
Current/nightly docs can continue to use grpc-* naming.

Checklist

  • Please confirm that all corresponding versions of the documents have been revised.
  • Please ensure that the content in sidebars.ts matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

Copilot AI linked an issue Jun 2, 2026 that may be closed by this pull request
Update docs for fix: align gRPC CLI option names with config naming #2435
Open
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying greptime-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08cf0d8
Status: ✅  Deploy successful!
Preview URL: https://50d03097.greptime-docs.pages.dev
Branch Preview URL: https://copilot-update-docs-align-gr.greptime-docs.pages.dev

View logs

Copilot AI changed the title [WIP] Update docs for fix: align gRPC CLI option names with config naming docs: align version-1.0 gRPC CLI flags with config naming Jun 2, 2026
Copilot AI requested a review from fengjiachun June 2, 2026 03:52
@fengjiachun

fengjiachun commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@codex review

@fengjiachun fengjiachun marked this pull request as ready for review June 2, 2026 06:18
@fengjiachun fengjiachun requested a review from killme2008 as a code owner June 2, 2026 06:18
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 2, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5290876825

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread versioned_docs/version-1.0/getting-started/installation/greptimedb-standalone.md Outdated
@fengjiachun

fengjiachun commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@copilot Please revert the version-1.0 doc changes from rpc-* to grpc-*. GreptimeDB PR #8021 is merged into main, but it is not included in stable v1.0.0, v1.0.1, or v1.0.2; it only appears in nightly tags. I also checked greptime/greptimedb:v1.0.2, and standalone/frontend start --help still uses --rpc-bind-addr / --rpc-server-addr, while --grpc-* is rejected. The grpc-* naming should stay in current/nightly docs only, not version-1.0.

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please revert the version-1.0 doc changes from rpc-* to grpc-*. GreptimeDB PR #8021 is merged into main, but it is not included in stable v1.0.0, v1.0.1, or v1.0.2; it only appe...

Done in 08cf0d8 — reverted all version-1.0 EN/ZH docs from grpc-* back to rpc-* for the affected installation and command-line pages.

Copilot AI changed the title docs: align version-1.0 gRPC CLI flags with config naming docs: revert version-1.0 CLI flags from grpc-* back to rpc-* Jun 3, 2026
@fengjiachun fengjiachun requested a review from sunng87 June 3, 2026 04:03
@fengjiachun

fengjiachun commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@v0y4g3r v0y4g3r closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

@killme2008 killme2008 Awaiting requested review from killme2008

@sunng87 sunng87 Awaiting requested review from sunng87

Assignees

@fengjiachun fengjiachun

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update docs for fix: align gRPC CLI option names with config naming

3 participants

@fengjiachun @v0y4g3r