fix(audit): align AccountExpired/Deleted severities; bump AuthLoginSuccess to Notice#23
Merged
Merged
Conversation
…ccess to Notice Two severity inconsistencies surfaced during the audit-events review. - AccountExpired was emitted at Notice while AccountDeleted (a parallel terminal account state) was emitted at Warning. Operators wiring an "any final-state account event" alert had to remember which kind carried which level. Aligned AccountExpired to Warning. - AuthLoginSuccess was emitted at Informational (syslog 6), a level most production log pipelines suppress by default. The failure counterpart fires at Warning, so the success/failure ratio that drives many login-anomaly alerts had a silently empty numerator unless operators specifically lowered their threshold. Bumped to Notice (syslog 5) to match account-unlock and key-rotation choices. Closes #19
3 tasks
rrrodzilla
added a commit
that referenced
this pull request
May 28, 2026
Reflects the audit-event work that landed in #14, #21, #22 and is queued in #23, #25: - audit/page.md: rewrite the "Auth Events (Automatic)" table to match the new emission set (AuthLoginSuccess at Notice; AuthTokenMissing / AuthTokenInvalid added; AuthTokenRevoked notes jti metadata; AuthPermissionDenied and HttpRequestDenied added); update the syslog and OTLP example severities to Notice; expand the "Event Kinds" reference table; add a migration callout for AuthLoginFailed. - cedar-auth/page.md: add "Audit Integration" section describing automatic AuthPermissionDenied emission on Decision::Deny. - rate-limiting/page.md: add "Audit Integration" section describing automatic HttpRequestDenied emission on RateLimitExceeded. - token-auth/page.md: add "Audit Emission" section covering the four middleware-emitted kinds, the jti correlation field, and the AuthLoginFailed migration. Refs #13 #15 #16 #18 #19
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two severity inconsistencies from #19.
AccountExpiredwas emitted atNoticewhileAccountDeleted(a parallel terminal account state) was emitted atWarning. Operators wiring an "any final-state account event" alert had to remember which kind carried which level. AlignedAccountExpiredtoWarning.AuthLoginSuccesswas emitted atInformational(syslog 6), a level most production log pipelines suppress by default. Failures fire atWarning, so the success/failure ratio that drives many login-anomaly alerts had a silently empty numerator unless operators specifically lowered their threshold. Bumped toNotice(syslog 5) to match account-unlock and key-rotation choices.Closes #19.
Breaking-ish
Severity levels are observable to downstream alerting. Downstream filters keyed on the old levels need recalibration. Call out in release notes.
Test plan
cargo clippy -p acton-service --all-targets --features full -- -D warnings— cleancargo clippy -p acton-service --all-targets --no-default-features --features "full,crypto-ring" -- -D warnings— cleancargo nextest run -p acton-service --features full— 520/520 pass