Skip to content

DRAFT: Add 02a-nsxt-tf-var stage and additional FW options#60

Open
afda16 wants to merge 1 commit into
mainfrom
feat/02a-nsxt-tf-var
Open

DRAFT: Add 02a-nsxt-tf-var stage and additional FW options#60
afda16 wants to merge 1 commit into
mainfrom
feat/02a-nsxt-tf-var

Conversation

@afda16

@afda16 afda16 commented Jul 23, 2023

Copy link
Copy Markdown

Add a new 02a-nsxt-tf-var stage, this can be implemented instead of the original 02a-nsxt.

02a-nsxt-tf-var is similar to 02a-nsxt but uses extended options for all the resources in the stage. This is in preparation for other stages that should expose all options available in the NSX-T resources.

To implement per app resources, for example groups or distributed firewall policies, there is a single Terraform variable, that accepts a list of resource configurations.

Additionally, add more options available to the
nsxt-distributed-firewall-policy module, so we can expose them in the 02a-nsxt-tf-var module.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Add a new 02a-nsxt-tf-var stage, this can be implemented instead of the
original 02a-nsxt.

02a-nsxt-tf-var is similar to 02a-nsxt but uses extended options for all
the resources in the stage. This is in preparation for other stages that
should expose all options available in the NSX-T resources.

To implement per app resources, for example groups or distributed
firewall policies, there is a single Terraform variable, that accepts a
list of resource configurations.

Additionally, add more options available to the
nsxt-distributed-firewall-policy module, so we can expose them in the
02a-nsxt-tf-var module.
@afda16
afda16 requested a review from a team as a code owner July 23, 2023 21:04
@afda16 afda16 changed the title Add 02a-nsxt-tf-var stage and additional FW options DRAFT: Add 02a-nsxt-tf-var stage and additional FW options Jul 23, 2023
@KonradSchieban

Copy link
Copy Markdown
Collaborator

Thank you for your contribution @afda16 ! Are you suggesting to replace the existing stage 02a-nsxt with the one you added or having them as alternatives? If it should replaced, I suggest we remove the existing folder with the content you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants