-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add project-context.md for datastream-to-spanner #3902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aasthabharill
wants to merge
2
commits into
GoogleCloudPlatform:main
Choose a base branch
from
aasthabharill:datastream-to-spanner-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| digraph Architecture { | ||
| node [shape=box, fontname="Helvetica", style=filled, fillcolor=lightblue]; | ||
|
|
||
| Datastream [label="Source DB\n(via Datastream)", shape=cylinder]; | ||
| GCS [label="Google Cloud Storage\n(AVRO/JSON)", shape=folder]; | ||
| Spanner [label="Cloud Spanner\n(Destination & Shadow Tables)", shape=cylinder]; | ||
| DLQ [label="Dead Letter Queue\n(GCS)", shape=folder]; | ||
| FilteredEventsGCS [label="Filtered Events\n(GCS)", shape=folder]; | ||
|
|
||
| subgraph cluster_dataflow { | ||
| label="Cloud Dataflow (DataStreamToSpanner)"; | ||
| fontname="Helvetica-Bold"; | ||
| style=dashed; | ||
| color=gray; | ||
|
|
||
| ReadDataStream [label="DataStreamIO\n(Read Events)"]; | ||
| ProcessSchema [label="Process Information Schema\n(Read DDL)"]; | ||
| ReadDLQ [label="FileBasedDeadLetterQueueReconsumer\n(Read from DLQ)"]; | ||
| Reshuffle [label="Reshuffle\n(Random Key)"]; | ||
| TransformEvents [label="Apply Transformation to events"]; | ||
| WriteSpanner [label="Write events to Cloud Spanner"]; | ||
| WriteFiltered [label="Write Filtered Events"]; | ||
| WriteDLQRetry [label="Write To DLQ\n(Retryable Errors)"]; | ||
| WriteDLQSevere [label="Write To DLQ2\n(Severe Errors)"]; | ||
| } | ||
|
|
||
| Datastream -> GCS [label=" Change Events"]; | ||
| GCS -> ReadDataStream; | ||
| Spanner -> ProcessSchema [label=" DDL"]; | ||
| ProcessSchema -> TransformEvents [label=" SideInput: DDL View", style=dotted]; | ||
| ProcessSchema -> WriteSpanner [label=" SideInput: DDL View", style=dotted]; | ||
| DLQ -> ReadDLQ [label=" Failed Events"]; | ||
|
|
||
| ReadDataStream -> Reshuffle; | ||
| ReadDLQ -> Reshuffle [label=" Retryable Events"]; | ||
| ReadDLQ -> WriteDLQSevere [label=" Permanent Errors"]; | ||
|
|
||
| Reshuffle -> TransformEvents [label=" JSON Records"]; | ||
| TransformEvents -> WriteFiltered [label=" Filtered Events"]; | ||
| WriteFiltered -> FilteredEventsGCS; | ||
| TransformEvents -> WriteSpanner [label=" Transformed Events"]; | ||
| TransformEvents -> WriteDLQSevere [label=" Permanent Errors"]; | ||
|
|
||
| WriteSpanner -> Spanner [label=" Spanner Mutations"]; | ||
| WriteSpanner -> WriteDLQRetry [label=" Retryable Errors"]; | ||
| WriteSpanner -> WriteDLQSevere [label=" Permanent Errors"]; | ||
|
|
||
| WriteDLQRetry -> DLQ; | ||
| WriteDLQSevere -> DLQ; | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The label
Write To DLQ2is misleading because there is no separateDLQ2resource or parameter configured in the pipeline. Both retryable and severe errors are written to the same Dead Letter Queue (DLQ) directory under different subdirectories (/tmp_retry/and/tmp_severe/). Labeling this asWrite To Severe DLQis more accurate and avoids confusion. Please regenerate thearchitecture.svgfile after applying this change to keep them in sync.