Replace JLine static Log reference with SLF4J Logger instance#3887
Replace JLine static Log reference with SLF4J Logger instance#3887JackPGreen wants to merge 1 commit into
Log reference with SLF4J Logger instance#3887Conversation
The class(es) declare a SLF4J `Logger LOG` field, but sometimes the JLine `Log` static class is referenced instead. It makes no sense to swap logging implementations mid-class, _my assumption_ is that it's an error by referencing the class instead of the field.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes logging practices by replacing references to the JLine 'Log' utility with the project-standard SLF4J 'Logger'. This ensures consistent logging behavior and improves maintainability by leveraging the existing logger instances defined within the classes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the usage of org.jline.utils.Log with standard SLF4J Logger (LOG) across multiple classes, including CassandraConnector, CassandraSchemaDiscovery, JdbcDataSource, CassandraAllDataTypesIT, and ChangeEventToMapConvertor. This standardizes logging across these components. There are no review comments to address, and I have no additional feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3887 +/- ##
============================================
+ Coverage 55.55% 63.31% +7.76%
+ Complexity 7026 2315 -4711
============================================
Files 1103 514 -589
Lines 67573 29933 -37640
Branches 7581 3298 -4283
============================================
- Hits 37537 18953 -18584
+ Misses 27621 10017 -17604
+ Partials 2415 963 -1452
🚀 New features to boost your workflow:
|
2 participants
The class(es) declare a SLF4J
Logger LOGfield, but sometimes the JLineLogstatic class is referenced instead.It makes no sense to swap logging implementations mid-class, my assumption is that it's an error by referencing the class instead of the field.