Add postgres float 4 to pg dialect float4 support in bulk migration#3885
Add postgres float 4 to pg dialect float4 support in bulk migration#3885sm745052 wants to merge 2 commits into
Conversation
Updated `AvroToValueMapper.java` to support `Type.pgFloat4()` in the `getPgMap()` method. It correctly maps the `pgFloat4` to Spanner `Value.float32`. Co-authored-by: sm745052 <79754058+sm745052@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Avro to Spanner value mapping logic to include support for the PostgreSQL float4 data type. This ensures that data migration processes correctly handle 32-bit floating-point values when targeting Spanner. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
============================================
+ Coverage 55.54% 63.28% +7.73%
+ Complexity 6574 2315 -4259
============================================
Files 1103 514 -589
Lines 67570 29952 -37618
Branches 7581 3300 -4281
============================================
- Hits 37531 18954 -18577
+ Misses 27624 10035 -17589
+ Partials 2415 963 -1452
🚀 New features to boost your workflow:
|
Co-authored-by: sm745052 <79754058+sm745052@users.noreply.github.com>
Add support for mapping
pgFloat4type in bulk migrations targeting Spanner. This correctly maps Avro to value mapping.PR created automatically by Jules for task 9270526303072825437 started by @sm745052