Skip to content

[googlecloud-to-googlecloud] Add Spanner Capture Type: NEW_ROW_AND_OLD_VALUES for AVRO files #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahlie88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[googlecloud-to-googlecloud] Add Spanner Capture Type: NEW_ROW_AND_OLD_VALUES for AVRO files #3846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...d/src/main/java/com/google/cloud/teleport/v2/transforms/WriteDataChangeRecordsToAvro.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ private static com.google.cloud.teleport.v2.ValueCaptureType mapValueCaptureType
return com.google.cloud.teleport.v2.ValueCaptureType.OLD_AND_NEW_VALUES;
case NEW_ROW:
return com.google.cloud.teleport.v2.ValueCaptureType.NEW_ROW;
case NEW_ROW_AND_OLD_VALUES:
return com.google.cloud.teleport.v2.ValueCaptureType.NEW_ROW_AND_OLD_VALUES;
Comment on lines +213 to +214

@gemini-code-assist gemini-code-assist Bot May 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new capture type NEW_ROW_AND_OLD_VALUES is correctly added to the mapping. However, it is recommended to add a corresponding unit test in WriteDataChangeRecordsToAvroTest.java to verify that this new type is correctly mapped to the Avro equivalent. Currently, the existing tests only cover OLD_AND_NEW_VALUES.

default:
return com.google.cloud.teleport.v2.ValueCaptureType.NEW_VALUES;
}
Expand Down
4 changes: 2 additions & 2 deletions v2/googlecloud-to-googlecloud/src/main/resources/schema/avro/datachangerecord.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"type" : {
"name": "ValueCaptureType",
"type": "enum",
"symbols": ["OLD_AND_NEW_VALUES", "NEW_ROW", "NEW_VALUES"]
"symbols": ["OLD_AND_NEW_VALUES", "NEW_ROW", "NEW_VALUES", "NEW_ROW_AND_OLD_VALUES"]
}
},
{ "name" : "numberOfRecordsInTransaction", "type" : "long"},
Expand Down Expand Up @@ -89,4 +89,4 @@
{"name": "spannerInstanceId", "type": ["null", "string"], "default": null },
{"name": "outputMessageMetadata", "type": ["null", "string"], "default": null }
]
}
}