Fix CI warnings: suppress lusol.h alloc-size warning, use error_on=warning#46
Merged
Merged
Conversation
vissarion
commented
Jun 29, 2026
vissarion
commented
Member
- Add GCC diagnostic pragmas to suppress -Walloc-size-larger-than= in vendored lp_solve's lusol.h, which triggers on Windows 64-bit.
- Change rcmdcheck error_on from 'error' to 'warning' in all three CI workflows to match CRAN check standards.
…rning - Add -Wno-alloc-size-larger-than to lp_solve CFLAGS in Makevars.win to suppress spurious GCC warning on Windows 64-bit from vendored lp_solve's LUSOL_REALLOC macro expansions. - Change rcmdcheck error_on from 'error' to 'warning' in all three CI workflows to match CRAN check standards. Note: the GCC pragma approach in lusol.h was reverted because the warning fires at macro expansion call sites (lusol.c, lusol1.c, etc.), not at the macro definition, making pragmas in the header ineffective. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.