Rcpp wrapping for Shake and Bake / Billiard Shake and Bake#34
Rcpp wrapping for Shake and Bake / Billiard Shake and Bake#34ivajankovic wants to merge 6 commits into
Conversation
| if (HP.is_in(StartingPoint) == 0) { | ||
| throw Rcpp::exception("The given point is not in the interior of the polytope!"); | ||
| } | ||
| if (gaussian) { |
There was a problem hiding this comment.
If the boundary sampling algorithms are not selected then everything else should remain the same. Can you confirm that your changes does not break anything not related to boundary sampling?
There was a problem hiding this comment.
I tested the Boundary HR algorithms they work properly, my code shouldn't affect anything because it is just protects shake and bake sampling from obtaining interior starting point
| if (!set_starting_point) StartingPoint = InnerBall.first; | ||
| if (!set_mode && gaussian) mode = InnerBall.first; | ||
| if ((walk == shake_and_bake) || (walk == billiard_shake_bake)) { | ||
| if (!set_starting_point){ |
There was a problem hiding this comment.
what happens if the user does give a boundary point?
There was a problem hiding this comment.
this if loop just changes the starting point, everything else remains the same, it will just sample with the user given starting point
|
Thanks @ivajankovic! This is an important feature! I left a few comments. |
|
100D cube:
|
2 participants
Rcpp wrapping for previously implemented Shake and Bake / Billiard Shake and Bake algorithms within sample_points.cpp.