Fix compilation with Boost 1.90.0 by updating libgeoda submodule - #57
Merged
Conversation
Replace deprecated boost/geometry/multi/geometries/multi_point.hpp with boost/geometry/geometries/multi_point.hpp in libgeoda submodule to fix compilation with Boost 1.90.0 where deprecated headers were removed.
Copilot
AI
changed the title
[WIP] Fix compilation failure by updating Boost geometry include
Fix compilation with Boost 1.90.0 by updating deprecated geometry header
Dec 16, 2025
lixun910
marked this pull request as ready for review
December 16, 2025 18:03
lixun910
requested changes
Dec 16, 2025
Member
There was a problem hiding this comment.
There is a fix in the libgeoda submodule. Can you update the submodule libgeoda from main branch? b24f916
Contributor
Author
Copilot
AI
changed the title
Fix compilation with Boost 1.90.0 by updating deprecated geometry header
Fix compilation with Boost 1.90.0 by updating libgeoda submodule
Dec 16, 2025
lixun910
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package fails to compile with Boost 1.89.0+ due to removal of deprecated
boost/geometry/multiheaders.Changes
src/libgeodasubmodule from commit58bfd8atob24f916(main branch)#include <boost/geometry/multi/geometries/multi_point.hpp>fromweights/VoronoiUtils.cppThis was the only occurrence of the deprecated include in the codebase.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.