Skip to content

Fix compilation with Boost 1.90.0 by updating libgeoda submodule - #57

Merged
lixun910 merged 3 commits into
masterfrom
copilot/fix-boost-geometry-include
Dec 16, 2025
Merged

Fix compilation with Boost 1.90.0 by updating libgeoda submodule#57
lixun910 merged 3 commits into
masterfrom
copilot/fix-boost-geometry-include

Conversation

Copilot AI commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

The package fails to compile with Boost 1.89.0+ due to removal of deprecated boost/geometry/multi headers.

Changes

  • Updated src/libgeoda submodule from commit 58bfd8a to b24f916 (main branch)
  • The submodule update includes the official fix from libgeoda PR CRAN gcc-ASAN check error #11 which removes the deprecated #include <boost/geometry/multi/geometries/multi_point.hpp> from weights/VoronoiUtils.cpp

This was the only occurrence of the deprecated include in the codebase.

Original prompt

This section details on the original issue you should resolve

<issue_title>compilation failure with new BH 1.90.0</issue_title>
<issue_description>Installing the R package rgeoda on Alpine Linux fails, ending with

libgeoda/weights/VoronoiUtils.cpp:30:10: fatal error: boost/geometry/multi/geometries/multi_point.hpp: No such file or directory
   30 | #include <boost/geometry/multi/geometries/multi_point.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

The deprecated geometry/multi headers were removed in Boost 1.89.0.

According to https://www.boost.org/doc/libs/latest/libs/geometry/doc/html/geometry/reference/models/model_multi_point.html, the correct include directive is:

#include <boost/geometry/geometries/multi_point.hpp>

</issue_description>

<agent_instructions>libgeoda/weights/VoronoiUtils.cpp:30:10: fatal error: boost/geometry/multi/geometries/multi_point.hpp: No such file or directory
30 | #include <boost/geometry/multi/geometries/multi_point.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
The deprecated geometry/multi headers were removed in Boost 1.89.0.

According to https://www.boost.org/doc/libs/latest/libs/geometry/doc/html/geometry/reference/models/model_multi_point.html, the correct include directive is:

#include <boost/geometry/geometries/multi_point.hpp>

Please fix it</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Replace deprecated boost/geometry/multi/geometries/multi_point.hpp
with boost/geometry/geometries/multi_point.hpp in libgeoda submodule
to fix compilation with Boost 1.90.0 where deprecated headers were removed.
Copilot AI changed the title [WIP] Fix compilation failure by updating Boost geometry include Fix compilation with Boost 1.90.0 by updating deprecated geometry header Dec 16, 2025
Copilot AI requested a review from lixun910 December 16, 2025 16:24
@lixun910
lixun910 marked this pull request as ready for review December 16, 2025 18:03
Comment thread src/libgeoda

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fix in the libgeoda submodule. Can you update the submodule libgeoda from main branch? b24f916

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the libgeoda submodule to main branch (commit b24f916) in commit 6071491. This uses the official fix from libgeoda PR #11.

Copilot AI changed the title Fix compilation with Boost 1.90.0 by updating deprecated geometry header Fix compilation with Boost 1.90.0 by updating libgeoda submodule Dec 16, 2025
Copilot AI requested a review from lixun910 December 16, 2025 18:12
@lixun910
lixun910 merged commit a1e5816 into master Dec 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compilation failure with new BH 1.90.0

2 participants