Fix incorrect capacity multiplier crashing the game when using comparator on blood altar - #137
Merged
koolkrafter5 merged 2 commits intoJul 12, 2026
Conversation
koolkrafter5
approved these changes
Jul 12, 2026
koolkrafter5
enabled auto-merge (squash)
July 12, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!99 introduced comparator logic to get total amount of blood in player's soul network. Unfortunately using this new logic can crash the game with division by zero (VIDEO, also see attached crash log) and in some cases make your world impossible to join (actually happened in my singleplayer world on 2.8.4, also seen on dailies).
Debugging (or, more specifically, putting a logging statement in comparator code) has shown that in some cases
.getOrbMultiplier()returns 0 (interestingly, this does not happen on the first comparator reading, but instead multiplier drops from 1.56 to 0 in my world after some updates). Determining the actual root cause is beyond my abilities, but at least using a neutral element for default should prevent crashing.Fixes GTNewHorizons/GT-New-Horizons-Modpack#25627
Checklist
crash-2026-07-08_22.16.37-client.txt
fml-client-latest.log