Fix some issues in NEI handlers - #105
Merged
Merged
Conversation
Let blood orbs be scrolled in the alchemy recipe handler and calicnator handler (needs open PR for NEI to be merged to let other stacks to be scrolled, but this compiles fine without it) Remove double-checked locking in NEIConfig::getBloodOrbs Cache more values in CachedReagentInfo Don't cache color value because it can change depending on implementation of .getColorX Fix state leaking in CachedReagentInfo Fix problem when finding recipes for empty belljars
Dream-Master
added
the
🚧 Testing on Zeta
slprime
approved these changes
Oct 15, 2025
Dream-Master
enabled auto-merge (squash)
October 15, 2025 17:16
boubou19
pushed a commit
that referenced
this pull request
Oct 19, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Dream-Master
removed
the
🚧 Testing on Zeta
label-sync-bot-gtnh
Bot
added
the
Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let blood orbs be scrolled in the alchemy recipe handler and calcinator handler (needs GTNewHorizons/NotEnoughItems#698 to let other stacks to be scrolled, but this compiles fine without it)
Remove double-checked locking in NEIConfig::getBloodOrbs
Cache more values in CachedReagentInfo
Don't cache color value because it can change depending on implementation of .getColorX
Fix state leaking in CachedReagentInfo
Fix problem when finding recipes for empty belljars