refactor: Minor changes to DB interactions to make compatible with Oracle for EE#7930
refactor: Minor changes to DB interactions to make compatible with Oracle for EE#7930matthewelwell wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
github-actions
Bot
added
api
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7930 +/- ##
==========================================
+ Coverage 98.63% 98.65% +0.01%
==========================================
Files 1497 1497
Lines 59013 59812 +799
==========================================
+ Hits 58207 59006 +799
Misses 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
matthewelwell
requested review from
emyller and
khvn26
and removed request for
a team and
khvn26
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Visual Regression19 screenshots compared. See report for details. |
emyller
left a comment
emyller
left a comment
There was a problem hiding this comment.
One non-blocking question.
| counts = features.values("lifecycle_stage").annotate(count=Count("pk")) # type: ignore[misc] | ||
| summary: dict[LifecycleStage, int] = {stage: 0 for stage in LifecycleStage} | ||
| for stage_count in counts: | ||
| summary[stage_count["lifecycle_stage"]] = stage_count["count"] | ||
| counts = Counter(features.values_list("lifecycle_stage", flat=True)) # type: ignore[misc] | ||
| summary: dict[LifecycleStage, int] = { | ||
| stage: counts.get(stage, 0) for stage in LifecycleStage | ||
| } |
There was a problem hiding this comment.
Judging by the amount of features I can see in SaaS, this doesn't add much. Though I'd be really surprised if Oracle can't do count + group by together. 🤔 Did you see a specific error?
2 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
2 small refactors to feature lifecycle implementation code in order to resolve compatibility issues with Oracle DB in our enterprise image (further context here)
How did you test this code?
Let CI do it's thing!