Skip to content

fix: add navigation to identity page from segment members list #7927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyle-ssg wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −6
Open

fix: add navigation to identity page from segment members list #7927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/web/components/modals/CreateSegmentUsersTabContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ const CreateSegmentUsersTabContent: React.FC<
projectId={projectId}
segmentId={segmentId}
environmentId={selectedEnv.id}
environmentApiKey={selectedEnv.api_key}
count={selectedMembership?.count}
/>
) : (
Expand Down
16 changes: 10 additions & 6 deletions frontend/web/components/modals/SegmentMembersList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { FC, useEffect, useState } from 'react'
import { Link } from 'react-router-dom'
import PanelSearch from 'components/PanelSearch'
import Utils from 'common/utils/utils'
import useDebouncedSearch from 'common/useDebouncedSearch'
Expand All @@ -11,6 +12,7 @@ type SegmentMembersListProps = {
projectId: string | number
segmentId: number
environmentId: number
environmentApiKey: string
// Total members for the selected environment, from the segment's
// membership_counts. The list endpoint is cursor-paginated and returns no
// count, so this drives the title total rather than the pager.
Expand All @@ -24,6 +26,7 @@ type SegmentMembersListProps = {
// response carries the `next`/`previous` flags (via `transformCursorPaging`).
const SegmentMembersList: FC<SegmentMembersListProps> = ({
count,
environmentApiKey,
environmentId,
projectId,
segmentId,
Expand Down Expand Up @@ -74,14 +77,15 @@ const SegmentMembersList: FC<SegmentMembersListProps> = ({
// Cursor pagination cannot jump to an arbitrary page.
}}
renderRow={({ identifier }: SegmentMember, index: number) => (
<Row
className='list-item list-item-sm clickable'
<Link
to={`/project/${projectId}/environment/${environmentApiKey}/identities/${encodeURIComponent(
identifier,
)}`}
className='list-item list-item-sm clickable d-flex align-items-center px-3'
data-test={`segment-member-${index}`}
>
<Row space className='px-3'>
<div className='font-weight-medium'>{identifier}</div>
</Row>
</Row>
<div className='font-weight-medium'>{identifier}</div>
</Link>
)}
filterRow={() => true}
search={searchInput}
Expand Down
Loading