Skip to content

fix: make Headway bell icon clickable#7925

Open
kyle-ssg wants to merge 1 commit into
mainfrom
fix/headway-widget-clickable
Open

fix: make Headway bell icon clickable#7925
kyle-ssg wants to merge 1 commit into
mainfrom
fix/headway-widget-clickable

Conversation

@kyle-ssg

@kyle-ssg kyle-ssg commented Jul 1, 2026

Copy link
Copy Markdown
Member

The bell icon wasn't triggering Headway.show() because clicks weren't being captured. Added onClick handler to the icon wrapper span with stopPropagation to prevent double-firing from event bubbling.

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Fixes headway click target

How did you test this code?

Clicked bell icon

The bell icon wasn't triggering Headway.show() because clicks weren't
being captured. Added onClick handler to the icon wrapper span with
stopPropagation to prevent double-firing from event bubbling.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@kyle-ssg kyle-ssg requested a review from a team as a code owner July 1, 2026 11:56
@kyle-ssg kyle-ssg requested review from talissoncosta and removed request for a team July 1, 2026 11:56
@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jul 1, 2026 11:57am
flagsmith-frontend-staging Ready Ready Preview, Comment Jul 1, 2026 11:57am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jul 1, 2026 11:57am

Request Review

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7925 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7925 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7925 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7925 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7925 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7925 Finished ✅ Results

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  34.8 seconds
commit  d1f3465
info  🔄 Run: #17992 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  17.3 seconds
commit  d1f3465
info  🔄 Run: #17992 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 4 suites
duration  22.3 seconds
commit  d1f3465
info  🔄 Run: #17992 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  37.9 seconds
commit  d1f3465
info  🔄 Run: #17992 (attempt 1)

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

17 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants