feat(experimentation): default to control when rollout segment is created#7905
Draft
gagantrivedi wants to merge 1 commit into
Draft
feat(experimentation): default to control when rollout segment is created#7905gagantrivedi wants to merge 1 commit into
gagantrivedi wants to merge 1 commit into
Conversation
…ated When a feature is first added to an experiment's rollout, zero every variant's allocation on the feature's environment-default feature state so control (the unallocated remainder) receives 100% of out-of-rollout traffic. The rollout segment override keeps the experiment's own split. This only runs when the rollout segment is first created; tuning the rollout of a running experiment leaves the default allocations alone.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7905 +/- ##
==========================================
- Coverage 98.62% 98.56% -0.07%
==========================================
Files 1488 1488
Lines 58543 58558 +15
==========================================
- Hits 57737 57716 -21
- Misses 806 842 +36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
8451662 to
8275f6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to experiment rollout work.
Warning
WIP / draft.
When a feature is first added to an experiment's rollout — i.e. the moment the rollout system segment is created — we now zero every variant's allocation on the feature's environment-default feature state. Control is the implicit unallocated remainder, so this gives control 100% of out-of-rollout traffic while the experiment runs.
spec.multivariate_values).update_flagpath (v1/v2) rather than mutating allocations in place.How did you test this code?
Added unit tests (
make test):test_services.py):test_apply_experiment_rollout__first_rollout__zeroes_default_allocations— default allocations zeroed, override split preserved.test_apply_experiment_rollout__existing_segment__leaves_default_allocations— a later manual edit to the default survives a rollout update.test_experiment_views.py):test_post__with_experiment_rollout__zeroes_default_allocations— end-to-end create-with-rollout zeroes the default and preserves the override split (bothuserandmaster_api_key).mypy,ruff, andflagsmith-lint-testsall clean.