Add patch to enable building on Apple Silicon#30
Conversation
richard-vd
force-pushed
the
patch-m1-build
branch
2 times, most recently
from
943908a to
c593129
Compare
|
@richard-vd, any updates on this? |
|
I don't have write access to this repository to merge this PR and update the bottle, but if you want it working now then I suggest to have a look at the README.md and the recent commit history in my fork: https://github.com/richard-vd/homebrew-musl-cross. |
|
Like @richfelker in richfelker/musl-cross-make#129 (comment), I suspect the patches are right, and I believe they build a Hello World fine, but I would feel more confident pulling something with a solid justification or a backport from the GCC tree. Has upstream not fixed this yet? |
|
I doubt it breaks anything at runtime, but if it's not correct it could break building the toolchain for different hosts. That's why I'd like to see an explanation. |
|
Can confirm that using formula from this PR works for me. |
richard-vd
force-pushed
the
patch-m1-build
branch
from
c593129 to
43c3f85
Compare
|
Updated commit to include patch for gcc-10.3.0. |
|
Any updates? Can I help somehow? |
|
Have these patches made it into upstream? If not, why? I do believe that they work when tested, but I am trying to understand why we don't have an official upstream patch to backport. |
|
Last month this was committed to gcc master: gcc-mirror/gcc@834c8749 I will update the PR to use this patch instead. |
|
Awesome, thank you! |
|
Thanks! Updating the PR to use the official fix will be much appreciated, and suffices to document that it's a reasonable solution. |
|
@richard-vd friendly ping, do you want to import the new patch or should I go ahead with it? |
richard-vd
force-pushed
the
patch-m1-build
branch
from
43c3f85 to
6ee3329
Compare
|
I redid the Apple silicon patches for gcc-6.5.0 .. gcc-10.3.0 using commits from gcc upstream. The URL of this patch points to today's commit in richfelker/musl-cross-make#129. I hope both PRs can be merged now. |
|
@FiloSottile Friendly ping… richfelker/musl-cross-make#129 looks like it will not be merged soon, could you merge this one? |
|
Ah, yes, thank you for syncing with upstream! |
|
All the glory to @richard-vd , thanks for taking time to fix this! |
6 participants
Fixes #23. See also richfelker/musl-cross-make#129.