Inherit configs/discriminators from parent class + add option for discriminator to match current class#322
Open
kdkavanagh wants to merge 3 commits into
Open
Inherit configs/discriminators from parent class + add option for discriminator to match current class#322kdkavanagh wants to merge 3 commits into
kdkavanagh wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
========================================
Coverage 99.98% 99.98%
========================================
Files 101 101
Lines 11911 12062 +151
========================================
+ Hits 11909 12060 +151
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321
I initially had an impl (the first commit on this branch) that solely fixes the config-from-base-class issue, but in implementing that, I discovered the restriction against matching the current class w/ a discriminator. Adding support for that seems useful (for my usecases, anyway), and reduces code duplication (as compared to the impl in my first commit)