fix: use try/finally for Bilibili temp file cleanup in merge_bilibili_video_audio#725
Open
Arvuno wants to merge 1 commit into
Open
fix: use try/finally for Bilibili temp file cleanup in merge_bilibili_video_audio#725Arvuno wants to merge 1 commit into
Arvuno wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The original code has a temp file leak: and are assigned inside the statements but declared only within the block. If throws an exception before assignment (e.g., disk full, permission error), the variables are unbound and the cleanup code crashes. Additionally, bare is a Python anti-pattern.
Solution
Tests
No existing tests for this function — manual verification:
Risk / Compatibility