Skip to content

update#1113

Open
xuhuanzy wants to merge 25 commits into
EmmyLuaLs:mainfrom
xuhuanzy:update
Open

update#1113
xuhuanzy wants to merge 25 commits into
EmmyLuaLs:mainfrom
xuhuanzy:update

Conversation

@xuhuanzy

@xuhuanzy xuhuanzy commented Jun 14, 2026

Copy link
Copy Markdown
Member
  1. 重构泛型, 见 update generic #1096
  2. 移除 Attribute 标签, 现在他的定义行为与 c# 的类似
  3. 重构 hover signature

github-actions[bot]

This comment was marked as low quality.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates the custom @attribute tag in favor of standard @class declarations inheriting from a base Attribute class, removing the old attribute parsing and analysis code. It also introduces support for const generic modifiers (replacing std.ConstTpl<T>) and refactors parameter count and type checking into a unified param_check diagnostic module. Feedback on these changes highlights a recursive cleanup bug in call_hover.rs where type_id can be left in visiting_aliases on early return, a logic gap in param_count.rs that fails to emit diagnostics when both missing and redundant candidates are present, and compatibility issues with Option::is_none_or which requires Rust 1.82.0.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread crates/emmylua_ls/src/handlers/hover/function/call_hover.rs Outdated
Comment thread crates/emmylua_code_analysis/src/diagnostic/checker/param_check/param_count.rs Outdated
Comment thread crates/emmylua_ls/src/handlers/hover/function/call_hover.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant