Skip to content

fix(v14): SYS/MDL functions not working correctly#7479

Open
helloradiosky wants to merge 1 commit into
EdgeTX:mainfrom
helloradiosky:hrs-v14-sys-mdl
Open

fix(v14): SYS/MDL functions not working correctly#7479
helloradiosky wants to merge 1 commit into
EdgeTX:mainfrom
helloradiosky:hrs-v14-sys-mdl

Conversation

@helloradiosky

@helloradiosky helloradiosky commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Fixed the issue where SYS/MDL functions were not working in V14

Summary by CodeRabbit

  • New Features
    • Added platform support for a new radio device manufacturer and configuration.
    • Extended key-mapping behavior to the new platform configuration for consistent navigation control.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds MANUFACTURER_HELLORADIOSKY as a preprocessor definition for the PCBREV V14 build target. The navigation header then defines NAVIGATION_X7_HRS from that macro (when RADIO_T8 is absent) and extends the existing NAVIGATION_X7_RM key-mapping branch to cover NAVIGATION_X7_HRS as well.

Changes

HelloRadioSky Navigation Support

Layer / File(s) Summary
Build definition for V14 board revision
radio/src/targets/taranis/CMakeLists.txt
Adds -DMANUFACTURER_HELLORADIOSKY to the PCBREV STREQUAL V14 branch.
NAVIGATION_X7_HRS macro and key-mapping
radio/src/gui/navigation/navigation.h
Defines NAVIGATION_X7_HRS when MANUFACTURER_HELLORADIOSKY is set and RADIO_T8 is not, then includes it in the NAVIGATION_X7_RM key-mapping #elif condition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required template sections including issue reference, detailed summary of changes, and rationale. Add issue reference (Fixes #...), expand summary with technical details about MANUFACTURER_HELLORADIOSKY and NAVIGATION_X7_HRS changes, and explain why V14 needed these changes.
Title check ⚠️ Warning The title references 'SYS/MDL functions' but the changeset only adds manufacturer recognition and key-mapping for navigation configurations, with no visible changes to SYS/MDL functionality. Revise the title to accurately reflect the actual changes, such as 'Add HELLORADIOSKY manufacturer support for V14 navigation' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pfeerick pfeerick changed the title Fixed SYS/MDL functions were not working in V14 fix(v14): SYS/MDL functions not working correctly Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant