DSMP V2 Enhacements for 2.12.x#7469
Conversation
1. 16 channels (X-Plus channels) 2. Show Firmware date instead of just version 3. Automatically choose "Enable AETR".
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
It seems like your check for AETR will also match a few others ARTE, EATR, ERTA, RETA. The AETR setting on EdgeTX doesn't really do anything other than set some default model configurations. The way everything works now changing the radio from TAER to AETR doesn't have an impact on an existing models. With this change it will if this option is enabled. Maybe it's best just to let the user select this option and leave the automatic part out? |
|
You are right, need to add the other check. At least Ch2 (Ele). Since the mapping does not affect the Rud. |
|
Actually that is not always true, by far. They copy model from their old radio, which might have been set to whatever, and new radio is set differently. If there is automation, it must always work, not rely on luck. And since this setting is per model, it should be based on model settings; not radio |
|
I think the default is RETA and the debug code tests that... and fails? |
|
The setting for "AETR" is only done when you select that module type for the first time. If it is a copy of a plane that already uses a DSMP module, it will retain the old setting. Open to just letting the user check that the settings are correct, since it's only when setting up the plane the first time. |
|
Channel mapping exists on multiprotocol module, because various receiver type require different mappings. Here things are different because we deal only with DSM protocol, so there is a single 'correct' channel order. Models should therefore be configured for it |
|
Removed the automatic setting of "AETR". We can add it later when we have a better way to analyze the model settings. |



Fixes #7467
LemonRX is comming out soon with DSMP V2. Full-Size and "Lite" version.
The JR-size module uses the same hardware as the V1 Module, but with new firmware.
The "Lite"-Size is new hardware but the same electronic design. just a smaller size.
Both use the same firmware.
Summary of changes:
Spektrum Receivers
6. Forward Programming Support
7. Support up to 16 channels (X-Plus channels), Default to 12ch on the module screen
Most of the code was already there, but features turned on/off depending on the version of the module.
Code is backward compatible with V1 module.
Tested on TX16Mk2, RM Boxer. On Pocket sim since I don't have a "lite" module radio.
RX: LemonRX 7ch "TextGen", Spektrum AR637T, Orange RX DSM2 RX.