Skip to content

ENG-1681: Advanced Search dialog with split-view preview (Roam)#994

Draft
trangdoan982 wants to merge 4 commits into
mainfrom
eng-1681-advanced-search-search-dialog-ui-with-results-and-filtering
Draft

ENG-1681: Advanced Search dialog with split-view preview (Roam)#994
trangdoan982 wants to merge 4 commits into
mainfrom
eng-1681-advanced-search-search-dialog-ui-with-results-and-filtering

ui-ready

9de15da
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / eslint (apps/roam) completed May 6, 2026 in 0s

reviewdog [eslint (apps/roam)] report

reported by reviewdog 🐶

Findings (13)

apps/roam/src/components/AdvancedSearchDialog/ChipsSearchInput.tsx|102 col 53| Parameter name _ must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/FilterPopover.tsx|13 col 8| 'SortDir' is defined but never used @typescript-eslint/no-unused-vars
apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx|9 col 3| Type Property name :block/string must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx|10 col 3| Type Property name :block/order must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx|11 col 3| Type Property name :block/children must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx|15 col 3| Type Property name :node/title must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx|16 col 3| Type Property name :block/children must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/index.tsx|255 col 68| Unsafe return of an any typed value @typescript-eslint/no-unsafe-return
apps/roam/src/components/AdvancedSearchDialog/index.tsx|278 col 20| This assertion is unnecessary since it does not change the type of the expression @typescript-eslint/no-unnecessary-type-assertion
apps/roam/src/components/AdvancedSearchDialog/index.tsx|297 col 7| Object Literal Property name date_modified must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/index.tsx|298 col 7| Object Literal Property name date_created must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/index.tsx|300 col 7| Object Literal Property name most_connected must match one of the following formats: camelCase @typescript-eslint/naming-convention
apps/roam/src/components/AdvancedSearchDialog/index.tsx|502 col 19| Object Literal Property name Overlay must match one of the following formats: camelCase @typescript-eslint/naming-convention

Filtered Findings (0)

Annotations

Check warning on line 102 in apps/roam/src/components/AdvancedSearchDialog/ChipsSearchInput.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/ChipsSearchInput.tsx#L102 

Parameter name `_` must match one of the following formats: camelCase  @typescript-eslint/naming-convention
Raw output 
  102:53  warning  Parameter name `_` must match one of the following formats: camelCase  @typescript-eslint/naming-convention

Check warning on line 13 in apps/roam/src/components/AdvancedSearchDialog/FilterPopover.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/FilterPopover.tsx#L13 

'SortDir' is defined but never used  @typescript-eslint/no-unused-vars
Raw output 
  13:8  warning  'SortDir' is defined but never used  @typescript-eslint/no-unused-vars

Check warning on line 9 in apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx#L9 

Type Property name `:block/string` must match one of the following formats: camelCase    @typescript-eslint/naming-convention
Raw output 
   9:3  warning  Type Property name `:block/string` must match one of the following formats: camelCase    @typescript-eslint/naming-convention

Check warning on line 10 in apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx#L10 

Type Property name `:block/order` must match one of the following formats: camelCase     @typescript-eslint/naming-convention
Raw output 
  10:3  warning  Type Property name `:block/order` must match one of the following formats: camelCase     @typescript-eslint/naming-convention

Check warning on line 11 in apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx#L11 

Type Property name `:block/children` must match one of the following formats: camelCase  @typescript-eslint/naming-convention
Raw output 
  11:3  warning  Type Property name `:block/children` must match one of the following formats: camelCase  @typescript-eslint/naming-convention

Check warning on line 15 in apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx#L15 

Type Property name `:node/title` must match one of the following formats: camelCase      @typescript-eslint/naming-convention
Raw output 
  15:3  warning  Type Property name `:node/title` must match one of the following formats: camelCase      @typescript-eslint/naming-convention

Check warning on line 16 in apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/PreviewPane.tsx#L16 

Type Property name `:block/children` must match one of the following formats: camelCase  @typescript-eslint/naming-convention
Raw output 
  16:3  warning  Type Property name `:block/children` must match one of the following formats: camelCase  @typescript-eslint/naming-convention

Check warning on line 255 in apps/roam/src/components/AdvancedSearchDialog/index.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/index.tsx#L255 

Unsafe return of an `any` typed value                                                             @typescript-eslint/no-unsafe-return
Raw output 
  255:68  warning  Unsafe return of an `any` typed value                                                             @typescript-eslint/no-unsafe-return

Check warning on line 278 in apps/roam/src/components/AdvancedSearchDialog/index.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/index.tsx#L278 

This assertion is unnecessary since it does not change the type of the expression                 @typescript-eslint/no-unnecessary-type-assertion
Raw output 
  278:20  warning  This assertion is unnecessary since it does not change the type of the expression                 @typescript-eslint/no-unnecessary-type-assertion

Check warning on line 297 in apps/roam/src/components/AdvancedSearchDialog/index.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/index.tsx#L297 

Object Literal Property name `date_modified` must match one of the following formats: camelCase   @typescript-eslint/naming-convention
Raw output 
  297:7   warning  Object Literal Property name `date_modified` must match one of the following formats: camelCase   @typescript-eslint/naming-convention

Check warning on line 298 in apps/roam/src/components/AdvancedSearchDialog/index.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/index.tsx#L298 

Object Literal Property name `date_created` must match one of the following formats: camelCase    @typescript-eslint/naming-convention
Raw output 
  298:7   warning  Object Literal Property name `date_created` must match one of the following formats: camelCase    @typescript-eslint/naming-convention

Check warning on line 300 in apps/roam/src/components/AdvancedSearchDialog/index.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/index.tsx#L300 

Object Literal Property name `most_connected` must match one of the following formats: camelCase  @typescript-eslint/naming-convention
Raw output 
  300:7   warning  Object Literal Property name `most_connected` must match one of the following formats: camelCase  @typescript-eslint/naming-convention

Check warning on line 502 in apps/roam/src/components/AdvancedSearchDialog/index.tsx

See this annotation in the file changed.

@github-actions github-actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/AdvancedSearchDialog/index.tsx#L502 

Object Literal Property name `Overlay` must match one of the following formats: camelCase         @typescript-eslint/naming-convention
Raw output 
  502:19  warning  Object Literal Property name `Overlay` must match one of the following formats: camelCase         @typescript-eslint/naming-convention
View more details on GitHub Actions