FEE-840 Add Obsidian schema export/import flow#1156
Closed
trangdoan982 wants to merge 5 commits into
Closed
Conversation
Add a shared schema selection UI for export and import, support native save/open dialog flows, and implement import apply logic with ID/name matching plus provisional relation schema creation. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Consolidate export/import selection flows behind shared modal and state primitives, move schema transfer types into core Obsidian types, and rename spec archive validation utilities to clearer spec validation naming. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract shared JSON open/save dialog helpers and replace archive terminology with loaded schema file and preview stats in the import flow. Co-authored-by: Cursor <cursoragent@cursor.com>
Reduce file dialog and import logic to Electron-only flows, compute match plans once at preview, and use skip-or-create apply behavior while trusting the shared selection UI for dependency closure. Co-authored-by: Cursor <cursoragent@cursor.com>
…om domain types. Remove redundant SchemaNodeTypeLike/SchemaRelationTypeLike/SchemaRelationTripleLike and SchemaSelectionInitialValues by expressing them as Pick<> expressions over the existing DiscourseNode/DiscourseRelationType/DiscourseRelation types. Fold initial selection into the hook with an optional initialTemplateNames override, and fix the useEffect reset to depend only on resetKey rather than on a new-each-render object. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dg-schema-{vaultname}.json, including native save/open dialog flows with a download fallbackExport discourse graph schemaandImport discourse graph schemacommands plus settings entry pointsTest plan
pnpm --filter @discourse-graphs/obsidian check-typespnpm --filter @discourse-graphs/obsidian exec eslint src/components/SchemaSelectionPanel.tsx src/components/ExportSpecsModal.tsx src/components/ImportSpecsModal.tsx src/utils/specArchive.ts src/utils/specExport.ts src/utils/specImport.ts src/utils/registerCommands.ts src/components/GeneralSettings.tsxMade with Cursor