Skip to content

ENG-1948: Fix publish.ts script#1155

Merged
trangdoan982 merged 5 commits into
mainfrom
eng-1948-fix-publish-script
Jun 26, 2026
Merged

ENG-1948: Fix publish.ts script#1155
trangdoan982 merged 5 commits into
mainfrom
eng-1948-fix-publish-script

Conversation

@trangdoan982

@trangdoan982 trangdoan982 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

  • add resilient GitHub API handling in Obsidian publish.ts with secondary-rate-limit retry/backoff
  • reduce API pressure by skipping unchanged files and uploading changed blobs in small batches
  • mirror source state into discourse-graph-obsidian by propagating deletions as part of tree updates
  • add LICENSE to apps/obsidian to ensure we have license in discourse-graph-obsidian too. This file is a completely copy of what we have in monorepo

Test plan

  • Run TypeScript lint diagnostics for apps/obsidian/scripts/publish.ts
  • Run tsx scripts/publish.ts --version <test-version> with a token in a safe test scenario
  • Confirm target repo reflects file updates and deletions after publish
    Obsidian release 1.4.2 was created with this script and passed all live testing.
    Made with Cursor

Open in Devin Review

Reduce GitHub secondary rate-limit failures during publish by batching/retrying blob uploads and mirror deletions so the target plugin repo stays in sync with source state.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jun 26, 2026 6:01pm

Request Review

@linear-code

linear-code Bot commented Jun 23, 2026

Copy link
Copy Markdown

ENG-1948

@supabase

supabase Bot commented Jun 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment thread apps/obsidian/scripts/publish.ts
Comment thread apps/obsidian/scripts/publish.ts
@graphite-app

graphite-app Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

Suppress strict ESLint checks in publish.ts to unblock PR feedback while keeping the rate-limit and release hardening logic intact.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mdroidian

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e008ad1ff2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/obsidian/scripts/publish.ts

@mdroidian mdroidian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See codex's comment

Remove package.json scripts from the mirrored Obsidian publish repo when scripts/ is excluded so the target repo does not contain broken script entries.

Co-authored-by: Cursor <cursoragent@cursor.com>
@trangdoan982 trangdoan982 merged commit aba0421 into main Jun 26, 2026
9 checks passed
@trangdoan982 trangdoan982 deleted the eng-1948-fix-publish-script branch June 26, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants