Search API Extension - #1486
Draft
psilabs-dev wants to merge 2 commits into
Draft
Conversation
psilabs-dev
force-pushed
the
dev-search/main
branch
from
April 12, 2026 03:17
7e70865 to
81f82f6
Compare
psilabs-dev
force-pushed
the
dev-search/main
branch
from
April 30, 2026 03:16
51bf191 to
53849c2
Compare
psilabs-dev
force-pushed
the
dev-search/main
branch
2 times, most recently
from
June 8, 2026 05:44
7e81a50 to
af688ef
Compare
psilabs-dev
marked this pull request as ready for review
June 8, 2026 05:45
psilabs-dev
force-pushed
the
dev-search/main
branch
from
June 22, 2026 04:27
af688ef to
eb6ecf1
Compare
psilabs-dev
marked this pull request as draft
June 23, 2026 23:33
psilabs-dev
force-pushed
the
dev-search/main
branch
from
June 29, 2026 00:49
eb6ecf1 to
5b3e464
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1226
(this might take a while)
Generalization of existing search API to support OR/NOT clauses. Due to the UI design, the PR feature is limited to category AND filter composition, with filters supporting OR composition (at least, that's what I find visually sensible w/o cluttering the UI in an unseemly way, might need to try it out more). However, the API should support a wide variety of use cases, which third-party clients may readily take advantage of if their UI layer accomodates this customization.
This PR will be broken down to several phases:
do_composite_search_innerandsearch_corebecome supersets of existing search functionality, will be unit-tested and checked for regressions."/api/search" and "/search" are subsets of "/api/search/composite", so we should be able to swap their internal logic with the composite search algorithm and find no behavioral difference.
I consider the important parts of the PR to be the API schema (which decides how everything will be implemented), and what is expected of search functionality. If the API changes, then all UI based on this API will change. From a UI perspective, will have to think about how to design this in a way that is still aesthetically acceptable.
Given the presence of JSON filtering data I've opted to switch to POST.
Regarding the core search functionality, you'll notice that the search algorithm does not concern itself with categories, as they are logically reducible.
isneg) pre-filtering.So category operations live around the search algorithm, in the form of pre/post-search filtering.
A proof-of-concept UI: ability to select multiple categories in AND composition, combined with OR composition of multiple search filters (which by themselves are AND clauses). On re-draw, the UI joins the categories into each OR part.
Still eye-balling #1438, as discussions there affect the API design. The current direction is probably still safe in terms of tank-related extensibility.