Skip to content

Use DeviceMap for TemperatureSensor - #2140

Merged
Relm-Arrowny merged 15 commits into
2113-i10-1-high-field-magnetic-controllersfrom
Use_device_vector_for_temperature_controller
Jul 30, 2026
Merged

Use DeviceMap for TemperatureSensor#2140
Relm-Arrowny merged 15 commits into
2113-i10-1-high-field-magnetic-controllersfrom
Use_device_vector_for_temperature_controller

Conversation

@oliwenmandiamond

Copy link
Copy Markdown
Contributor

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.17%. Comparing base (b6c9f7b) to head (48be28f).
⚠️ Report is 1 commits behind head on 2113-i10-1-high-field-magnetic-controllers.

Additional details and impacted files
@@                              Coverage Diff                               @@
##           2113-i10-1-high-field-magnetic-controllers    #2140      +/-   ##
==============================================================================
+ Coverage                                       99.10%   99.17%   +0.07%     
==============================================================================
  Files                                             357      357              
  Lines                                           14026    14011      -15     
==============================================================================
- Hits                                            13900    13895       -5     
+ Misses                                            126      116      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny changed the title Use DeviceVector for TemperatureSensor Use DeviceMap for TemperatureSensor Jul 30, 2026
@Relm-Arrowny
Relm-Arrowny marked this pull request as ready for review July 30, 2026 14:47
@Relm-Arrowny
Relm-Arrowny requested a review from a team as a code owner July 30, 2026 14:47
@Relm-Arrowny
Relm-Arrowny merged commit bbe4013 into 2113-i10-1-high-field-magnetic-controllers Jul 30, 2026
11 checks passed
@Relm-Arrowny
Relm-Arrowny deleted the Use_device_vector_for_temperature_controller branch July 30, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants