Standardise config client and fix tests dependent on order they are ran - #2099
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2099 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 354 354
Lines 13831 13842 +11
=======================================
+ Hits 13715 13726 +11
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jacob720
left a comment
There was a problem hiding this comment.
Have discussed a bit with @DominicOram and I don't think we should care about converters in the mock client as conversion is a server-side process. In dodal we should assume we are receiving converted data from the server, and test data should conform to the post-conversion format.
The exception is where the force-parser option is used, which would force conversion to take place client side, but this is already handled by the existing fixture and should only be a temporary measure wherever it's used.
Villtord
left a comment
There was a problem hiding this comment.
Sorry I've got a few questions while I was reading it through.
…/DiamondLightSource/dodal into standardise_config_server_in_tests
Fixes #2098 and Fixes #2131
Instructions to reviewer on how to test:
dodal/tests/common/beamlines/test_device_instantiation.py::test_device_creation[iXX]in main branch and this branch. Confirm they now pass and doesn't depend on order.Checks for reviewer
dodal connect ${BEAMLINE}